[PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Martijn de Gouw]

Make the PWM mode on the buck controllers configurable from devicetree.
Some boards require forced PWM mode to keep the supply ripple within
acceptable limits under light load conditions.

Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
---
Changes in v3:
  - Fix typo in the examples
Changes in v2:
  - Add the header to the binding patch
  - Improve commit message

 .../regulator/nxp,pca9450-regulator.yaml       | 14 ++++++++++++++
 .../regulator/nxp,pca9450-regulator.h          | 18 ++++++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 include/dt-bindings/regulator/nxp,pca9450-regulator.h

diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
index 4ffe5c3faea07..a5486c36830f0 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
@@ -100,6 +100,15 @@ properties:
               PMIC default "STANDBY" state voltage in uV. Only Buck1~3 have such
               dvs(dynamic voltage scaling) property.
 
+          regulator-allowed-modes:
+            description: |
+              Buck regulator operating modes allowed. Valid values below.
+              Users should use the macros from dt-bindings/regulator/nxp,pca9450-regulator.h
+                0 (PCA9450_BUCK_MODE_AUTO): Auto PFM/PWM mode
+                1 (PCA9450_BUCK_MODE_FORCE_PWM): Forced PWM mode
+            items:
+              enum: [ 0, 1 ]
+
         unevaluatedProperties: false
 
     additionalProperties: false
@@ -143,6 +152,7 @@ allOf:
 examples:
   - |
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/regulator/nxp,pca9450-regulator.h>
 
     i2c {
         #address-cells = <1>;
@@ -179,6 +189,8 @@ examples:
                     regulator-max-microvolt = <3400000>;
                     regulator-boot-on;
                     regulator-always-on;
+                    regulator-initial-mode = <PCA9450_BUCK_MODE_FORCE_PWM>;
+                    regulator-allowed-modes = <PCA9450_BUCK_MODE_FORCE_PWM>;
                 };
                 buck5: BUCK5 {
                     regulator-name = "BUCK5";
@@ -186,6 +198,8 @@ examples:
                     regulator-max-microvolt = <3400000>;
                     regulator-boot-on;
                     regulator-always-on;
+                    regulator-allowed-modes = <PCA9450_BUCK_MODE_AUTO
+                                               PCA9450_BUCK_MODE_FORCE_PWM>;
                 };
                 buck6: BUCK6 {
                     regulator-name = "BUCK6";
diff --git a/include/dt-bindings/regulator/nxp,pca9450-regulator.h b/include/dt-bindings/regulator/nxp,pca9450-regulator.h
new file mode 100644
index 0000000000000..08434caef429f
--- /dev/null
+++ b/include/dt-bindings/regulator/nxp,pca9450-regulator.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Device Tree binding constants for the NXP PCA9450A/B/C PMIC regulators
+ */
+
+#ifndef _DT_BINDINGS_REGULATORS_NXP_PCA9450_H
+#define _DT_BINDINGS_REGULATORS_NXP_PCA9450_H
+
+/*
+ * Buck mode constants which may be used in devicetree properties (eg.
+ * regulator-initial-mode, regulator-allowed-modes).
+ * See the manufacturer's datasheet for more information on these modes.
+ */
+
+#define PCA9450_BUCK_MODE_AUTO		0
+#define PCA9450_BUCK_MODE_FORCE_PWM	1
+
+#endif
-- 
2.39.2

Re: [PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

On Sun, May 25, 2025 at 09:18:20AM +0200, Martijn de Gouw wrote:
> Make the PWM mode on the buck controllers configurable from devicetree.
> Some boards require forced PWM mode to keep the supply ripple within
> acceptable limits under light load conditions.
> 
> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Martijn de Gouw]

Hi,

On 5/25/2025 9:18 AM, Martijn de Gouw wrote:
> Make the PWM mode on the buck controllers configurable from devicetree.
> Some boards require forced PWM mode to keep the supply ripple within
> acceptable limits under light load conditions.
> 
> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
> ---
> Changes in v3:
>   - Fix typo in the examples
> Changes in v2:
>   - Add the header to the binding patch
>   - Improve commit message
> 
>  .../regulator/nxp,pca9450-regulator.yaml       | 14 ++++++++++++++
>  .../regulator/nxp,pca9450-regulator.h          | 18 ++++++++++++++++++
>  2 files changed, 32 insertions(+)

Does this patch need additional changes?

Regards, Martijn

Re: [PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Krzysztof Kozlowski]

On 04/06/2025 09:04, Martijn de Gouw wrote:
> Hi,
> 
> On 5/25/2025 9:18 AM, Martijn de Gouw wrote:
>> Make the PWM mode on the buck controllers configurable from devicetree.
>> Some boards require forced PWM mode to keep the supply ripple within
>> acceptable limits under light load conditions.
>>
>> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
>> ---
>> Changes in v3:
>>   - Fix typo in the examples
>> Changes in v2:
>>   - Add the header to the binding patch
>>   - Improve commit message
>>
>>  .../regulator/nxp,pca9450-regulator.yaml       | 14 ++++++++++++++
>>  .../regulator/nxp,pca9450-regulator.h          | 18 ++++++++++++++++++
>>  2 files changed, 32 insertions(+)
> 
> Does this patch need additional changes?

What is wrong with the email you already received? What do you exactly
need from us?

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Martijn de Gouw]

On 6/4/2025 10:27 AM, Krzysztof Kozlowski wrote:
> On 04/06/2025 09:04, Martijn de Gouw wrote:
>> Hi,
>>
>> On 5/25/2025 9:18 AM, Martijn de Gouw wrote:
>>> Make the PWM mode on the buck controllers configurable from devicetree.
>>> Some boards require forced PWM mode to keep the supply ripple within
>>> acceptable limits under light load conditions.
>>>
>>> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
>>> ---
>>> Changes in v3:
>>>   - Fix typo in the examples
>>> Changes in v2:
>>>   - Add the header to the binding patch
>>>   - Improve commit message
>>>
>>>  .../regulator/nxp,pca9450-regulator.yaml       | 14 ++++++++++++++
>>>  .../regulator/nxp,pca9450-regulator.h          | 18 ++++++++++++++++++
>>>  2 files changed, 32 insertions(+)
>>
>> Does this patch need additional changes?
> 
> What is wrong with the email you already received? What do you exactly
> need from us?

V2 was merged rather quickly, on V3 there was only the Acked-by: Conor Dooley. So it's safe to assume V3 is now waiting to be merged?

Regards, Martijn

Re: [PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Krzysztof Kozlowski]

On 04/06/2025 10:58, Martijn de Gouw wrote:
> 
> 
> On 6/4/2025 10:27 AM, Krzysztof Kozlowski wrote:
>> On 04/06/2025 09:04, Martijn de Gouw wrote:
>>> Hi,
>>>
>>> On 5/25/2025 9:18 AM, Martijn de Gouw wrote:
>>>> Make the PWM mode on the buck controllers configurable from devicetree.
>>>> Some boards require forced PWM mode to keep the supply ripple within
>>>> acceptable limits under light load conditions.
>>>>
>>>> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
>>>> ---
>>>> Changes in v3:
>>>>   - Fix typo in the examples
>>>> Changes in v2:
>>>>   - Add the header to the binding patch
>>>>   - Improve commit message
>>>>
>>>>  .../regulator/nxp,pca9450-regulator.yaml       | 14 ++++++++++++++
>>>>  .../regulator/nxp,pca9450-regulator.h          | 18 ++++++++++++++++++
>>>>  2 files changed, 32 insertions(+)
>>>
>>> Does this patch need additional changes?
>>
>> What is wrong with the email you already received? What do you exactly
>> need from us?
> 
> V2 was merged rather quickly, on V3 there was only the Acked-by: Conor Dooley. So it's safe to assume V3 is now waiting to be merged?

So this was ping for merging of entire patchset, not that patch? There
is little point in pinging frequent and during the merge window -
usually nothing can happen now.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Martijn de Gouw]

On 6/4/2025 11:07 AM, Krzysztof Kozlowski wrote:
> On 04/06/2025 10:58, Martijn de Gouw wrote:
>>
>>
>> On 6/4/2025 10:27 AM, Krzysztof Kozlowski wrote:
>>> On 04/06/2025 09:04, Martijn de Gouw wrote:
>>>> Hi,
>>>>
>>>> On 5/25/2025 9:18 AM, Martijn de Gouw wrote:
>>>>> Make the PWM mode on the buck controllers configurable from devicetree.
>>>>> Some boards require forced PWM mode to keep the supply ripple within
>>>>> acceptable limits under light load conditions.
>>>>>
>>>>> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
>>>>> ---
>>>>> Changes in v3:
>>>>>   - Fix typo in the examples
>>>>> Changes in v2:
>>>>>   - Add the header to the binding patch
>>>>>   - Improve commit message
>>>>>
>>>>>  .../regulator/nxp,pca9450-regulator.yaml       | 14 ++++++++++++++
>>>>>  .../regulator/nxp,pca9450-regulator.h          | 18 ++++++++++++++++++
>>>>>  2 files changed, 32 insertions(+)
>>>>
>>>> Does this patch need additional changes?
>>>
>>> What is wrong with the email you already received? What do you exactly
>>> need from us?
>>
>> V2 was merged rather quickly, on V3 there was only the Acked-by: Conor Dooley. So it's safe to assume V3 is now waiting to be merged?
> 
> So this was ping for merging of entire patchset, not that patch? There
> is little point in pinging frequent and during the merge window -
> usually nothing can happen now.

Clear, thanks!

Regards, Martijn

Re: [PATCH v3 1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes

[Mark Brown]

On Sun, 25 May 2025 09:18:20 +0200, Martijn de Gouw wrote:
> Make the PWM mode on the buck controllers configurable from devicetree.
> Some boards require forced PWM mode to keep the supply ripple within
> acceptable limits under light load conditions.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes
      commit: d7181a2d43cffb19f1e5c19f6d2328f190c87d70
[2/2] regulator: pca9450: Add support for mode operations
      commit: 548d770c330cd1027549947a6ea899c56b5bc4e4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark