Re: [PATCH net-next v12 00/13] Add support for PSE budget evaluation strategy

[Kory Maincent <kory.maincent@bootlin.com>]

Le Wed, 28 May 2025 09:31:20 +0200,
Paolo Abeni <pabeni@redhat.com> a écrit :

> On 5/24/25 12:56 PM, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > 
> > This series brings support for budget evaluation strategy in the PSE
> > subsystem. PSE controllers can set priorities to decide which ports should
> > be turned off in case of special events like over-current.
> > 
> > This patch series adds support for two budget evaluation strategy.
> > 1. Static Method:
> > 
> >    This method involves distributing power based on PD classification.
> >    It’s straightforward and stable, the PSE core keeping track of the
> >    budget and subtracting the power requested by each PD’s class.
> > 
> >    Advantages: Every PD gets its promised power at any time, which
> >    guarantees reliability.
> > 
> >    Disadvantages: PD classification steps are large, meaning devices
> >    request much more power than they actually need. As a result, the power
> >    supply may only operate at, say, 50% capacity, which is inefficient and
> >    wastes money.
> > 
> > 2. Dynamic Method:
> > 
> >    To address the inefficiencies of the static method, vendors like
> >    Microchip have introduced dynamic power budgeting, as seen in the
> >    PD692x0 firmware. This method monitors the current consumption per port
> >    and subtracts it from the available power budget. When the budget is
> >    exceeded, lower-priority ports are shut down.
> > 
> >    Advantages: This method optimizes resource utilization, saving costs.
> > 
> >    Disadvantages: Low-priority devices may experience instability.
> > 
> > The UAPI allows adding support for software port priority mode managed from
> > userspace later if needed.
> > 
> > Patches 1-2: Add support for interrupt event report in PSE core, ethtool
> > 	     and ethtool specs.
> > Patch 3: Adds support for interrupt and event report in TPS23881 driver.
> > Patches 4,5: Add support for PSE power domain in PSE core and ethtool.
> > Patches 6-8: Add support for budget evaluation strategy in PSE core,
> > 	     ethtool and ethtool specs.
> > Patches 9-11: Add support for port priority and power supplies in PD692x0
> > 	      drivers.
> > Patches 12,13: Add support for port priority in TPS23881 drivers.
> > 
> > Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>  
> 
> I'm sorry, even if this has been posted (just) before the merge window,
> I think an uAPI extension this late is a bit too dangerous, please
> repost when net-next will reopen after the merge window.

Ok I will.
Would it be possible to review the netlink part of the series? (patch 2, 7 and
8) 

Regard,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com