* [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire
@ 2025-06-26 10:40 Antoniu Miclaus
2025-06-26 10:40 ` [PATCH 2/2] iio: adc: ad4851: add spi 3-wire support Antoniu Miclaus
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Antoniu Miclaus @ 2025-06-26 10:40 UTC (permalink / raw)
To: jic23, robh, conor+dt, devicetree, linux-iio, linux-kernel
Cc: Antoniu Miclaus
Add devicetree support for spi 3-wire configuration.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml
index c6676d91b4e6..b107322e0ea3 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml
@@ -69,6 +69,8 @@ properties:
spi-max-frequency:
maximum: 25000000
+ spi-3wire: true
+
'#address-cells':
const: 1
--
2.49.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] iio: adc: ad4851: add spi 3-wire support
2025-06-26 10:40 [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire Antoniu Miclaus
@ 2025-06-26 10:40 ` Antoniu Miclaus
2025-06-27 15:52 ` Nuno Sá
2025-06-27 21:33 ` [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire Rob Herring (Arm)
2025-06-28 15:23 ` Jonathan Cameron
2 siblings, 1 reply; 5+ messages in thread
From: Antoniu Miclaus @ 2025-06-26 10:40 UTC (permalink / raw)
To: jic23, robh, conor+dt, devicetree, linux-iio, linux-kernel
Cc: Antoniu Miclaus
Add support for 3-wire configuration within the driver.
By default 4-wire configuration is used.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/ad4851.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/ad4851.c b/drivers/iio/adc/ad4851.c
index 31e1e02c0ce3..1ad77f2a4580 100644
--- a/drivers/iio/adc/ad4851.c
+++ b/drivers/iio/adc/ad4851.c
@@ -444,10 +444,12 @@ static int ad4851_setup(struct ad4851_state *st)
if (ret)
return ret;
- ret = regmap_write(st->regmap, AD4851_REG_INTERFACE_CONFIG_A,
- AD4851_SDO_ENABLE);
- if (ret)
- return ret;
+ if (!(st->spi->mode & SPI_3WIRE)) {
+ ret = regmap_write(st->regmap, AD4851_REG_INTERFACE_CONFIG_A,
+ AD4851_SDO_ENABLE);
+ if (ret)
+ return ret;
+ }
ret = regmap_read(st->regmap, AD4851_REG_PRODUCT_ID_L, &product_id);
if (ret)
--
2.49.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] iio: adc: ad4851: add spi 3-wire support
2025-06-26 10:40 ` [PATCH 2/2] iio: adc: ad4851: add spi 3-wire support Antoniu Miclaus
@ 2025-06-27 15:52 ` Nuno Sá
0 siblings, 0 replies; 5+ messages in thread
From: Nuno Sá @ 2025-06-27 15:52 UTC (permalink / raw)
To: Antoniu Miclaus, jic23, robh, conor+dt, devicetree, linux-iio,
linux-kernel
On Thu, 2025-06-26 at 13:40 +0300, Antoniu Miclaus wrote:
> Add support for 3-wire configuration within the driver.
> By default 4-wire configuration is used.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
Had to look twice :). Commit message could have been better by saying that reset
value is 3-wire. Anyways:
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> drivers/iio/adc/ad4851.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/ad4851.c b/drivers/iio/adc/ad4851.c
> index 31e1e02c0ce3..1ad77f2a4580 100644
> --- a/drivers/iio/adc/ad4851.c
> +++ b/drivers/iio/adc/ad4851.c
> @@ -444,10 +444,12 @@ static int ad4851_setup(struct ad4851_state *st)
> if (ret)
> return ret;
>
> - ret = regmap_write(st->regmap, AD4851_REG_INTERFACE_CONFIG_A,
> - AD4851_SDO_ENABLE);
> - if (ret)
> - return ret;
> + if (!(st->spi->mode & SPI_3WIRE)) {
> + ret = regmap_write(st->regmap, AD4851_REG_INTERFACE_CONFIG_A,
> + AD4851_SDO_ENABLE);
> + if (ret)
> + return ret;
> + }
>
> ret = regmap_read(st->regmap, AD4851_REG_PRODUCT_ID_L, &product_id);
> if (ret)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire
2025-06-26 10:40 [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire Antoniu Miclaus
2025-06-26 10:40 ` [PATCH 2/2] iio: adc: ad4851: add spi 3-wire support Antoniu Miclaus
@ 2025-06-27 21:33 ` Rob Herring (Arm)
2025-06-28 15:23 ` Jonathan Cameron
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2025-06-27 21:33 UTC (permalink / raw)
To: Antoniu Miclaus; +Cc: devicetree, conor+dt, linux-iio, linux-kernel, jic23
On Thu, 26 Jun 2025 13:40:23 +0300, Antoniu Miclaus wrote:
> Add devicetree support for spi 3-wire configuration.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire
2025-06-26 10:40 [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire Antoniu Miclaus
2025-06-26 10:40 ` [PATCH 2/2] iio: adc: ad4851: add spi 3-wire support Antoniu Miclaus
2025-06-27 21:33 ` [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire Rob Herring (Arm)
@ 2025-06-28 15:23 ` Jonathan Cameron
2 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2025-06-28 15:23 UTC (permalink / raw)
To: Antoniu Miclaus; +Cc: robh, conor+dt, devicetree, linux-iio, linux-kernel
On Thu, 26 Jun 2025 13:40:23 +0300
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add devicetree support for spi 3-wire configuration.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Series applied.
Thanks,
Jonathan
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml
> index c6676d91b4e6..b107322e0ea3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml
> @@ -69,6 +69,8 @@ properties:
> spi-max-frequency:
> maximum: 25000000
>
> + spi-3wire: true
> +
> '#address-cells':
> const: 1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-28 15:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-26 10:40 [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire Antoniu Miclaus
2025-06-26 10:40 ` [PATCH 2/2] iio: adc: ad4851: add spi 3-wire support Antoniu Miclaus
2025-06-27 15:52 ` Nuno Sá
2025-06-27 21:33 ` [PATCH 1/2] dt-bindings: iio: adc: ad4851: add spi-3wire Rob Herring (Arm)
2025-06-28 15:23 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox