[PATCH] arm64: dts: imx94: add missing clock related properties to flexcan1

[PATCH] arm64: dts: imx94: add missing clock related properties to flexcan1

[Sherry Sun]

Somehow the flexcan1 clock related properties were missing in
imx94.dtsi, add them here to keep align with other flexcan instances.

Fixes: b0d011d4841b ("arm64: dts: freescale: Add basic dtsi for imx943")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx94.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx94.dtsi b/arch/arm64/boot/dts/freescale/imx94.dtsi
index b8ffc428e95b..bd3437146746 100644
--- a/arch/arm64/boot/dts/freescale/imx94.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx94.dtsi
@@ -1035,6 +1035,13 @@ flexcan1: can@443a0000 {
 				compatible = "fsl,imx94-flexcan", "fsl,imx95-flexcan";
 				reg = <0x443a0000 0x10000>;
 				interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&scmi_clk IMX94_CLK_BUSAON>,
+					 <&scmi_clk IMX94_CLK_CAN1>;
+				clock-names = "ipg", "per";
+				assigned-clocks = <&scmi_clk IMX94_CLK_CAN1>;
+				assigned-clock-parents = <&scmi_clk IMX94_CLK_SYSPLL1_PFD1_DIV2>;
+				assigned-clock-rates = <80000000>;
+				fsl,clk-source = /bits/ 8 <0>;
 				status = "disabled";
 			};
 
-- 
2.34.1

Re: [PATCH] arm64: dts: imx94: add missing clock related properties to flexcan1

[Frank Li]

On Wed, Jul 02, 2025 at 10:59:11AM +0800, Sherry Sun wrote:
> Somehow the flexcan1 clock related properties were missing in
> imx94.dtsi, add them here to keep align with other flexcan instances.

suggested commit message:

Add missing clocks and clock-names properties for flexcan1 in imx94.dtsi
to align with other FlexCAN instances.

Frank

>
> Fixes: b0d011d4841b ("arm64: dts: freescale: Add basic dtsi for imx943")
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx94.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx94.dtsi b/arch/arm64/boot/dts/freescale/imx94.dtsi
> index b8ffc428e95b..bd3437146746 100644
> --- a/arch/arm64/boot/dts/freescale/imx94.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx94.dtsi
> @@ -1035,6 +1035,13 @@ flexcan1: can@443a0000 {
>  				compatible = "fsl,imx94-flexcan", "fsl,imx95-flexcan";
>  				reg = <0x443a0000 0x10000>;
>  				interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&scmi_clk IMX94_CLK_BUSAON>,
> +					 <&scmi_clk IMX94_CLK_CAN1>;
> +				clock-names = "ipg", "per";
> +				assigned-clocks = <&scmi_clk IMX94_CLK_CAN1>;
> +				assigned-clock-parents = <&scmi_clk IMX94_CLK_SYSPLL1_PFD1_DIV2>;
> +				assigned-clock-rates = <80000000>;
> +				fsl,clk-source = /bits/ 8 <0>;
>  				status = "disabled";
>  			};
>
> --
> 2.34.1
>

RE: [PATCH] arm64: dts: imx94: add missing clock related properties to flexcan1

[Sherry Sun]

> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: Wednesday, July 2, 2025 11:44 AM
> To: Sherry Sun <sherry.sun@nxp.com>
> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com;
> Jacky Bai <ping.bai@nxp.com>; Bough Chen <haibo.chen@nxp.com>;
> devicetree@vger.kernel.org; imx@lists.linux.dev; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de
> Subject: Re: [PATCH] arm64: dts: imx94: add missing clock related properties
> to flexcan1
> 
> On Wed, Jul 02, 2025 at 10:59:11AM +0800, Sherry Sun wrote:
> > Somehow the flexcan1 clock related properties were missing in
> > imx94.dtsi, add them here to keep align with other flexcan instances.
> 
> suggested commit message:
> 
> Add missing clocks and clock-names properties for flexcan1 in imx94.dtsi to
> align with other FlexCAN instances.

Thanks, will improve this in V2.

Best Regards
Sherry

> 
> Frank
> 
> >
> > Fixes: b0d011d4841b ("arm64: dts: freescale: Add basic dtsi for
> > imx943")
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx94.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx94.dtsi
> > b/arch/arm64/boot/dts/freescale/imx94.dtsi
> > index b8ffc428e95b..bd3437146746 100644
> > --- a/arch/arm64/boot/dts/freescale/imx94.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx94.dtsi
> > @@ -1035,6 +1035,13 @@ flexcan1: can@443a0000 {
> >  				compatible = "fsl,imx94-flexcan", "fsl,imx95-
> flexcan";
> >  				reg = <0x443a0000 0x10000>;
> >  				interrupts = <GIC_SPI 10
> IRQ_TYPE_LEVEL_HIGH>;
> > +				clocks = <&scmi_clk IMX94_CLK_BUSAON>,
> > +					 <&scmi_clk IMX94_CLK_CAN1>;
> > +				clock-names = "ipg", "per";
> > +				assigned-clocks = <&scmi_clk
> IMX94_CLK_CAN1>;
> > +				assigned-clock-parents = <&scmi_clk
> IMX94_CLK_SYSPLL1_PFD1_DIV2>;
> > +				assigned-clock-rates = <80000000>;
> > +				fsl,clk-source = /bits/ 8 <0>;
> >  				status = "disabled";
> >  			};
> >
> > --
> > 2.34.1
> >