From: Jonathan Cameron <jic23@kernel.org>
To: Ioana Risteiu <Ioana.Risteiu@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ramona Nechita" <ramona.nechita@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] iio: adc: adi-axi-adc: add axi_adc_num_lanes_set
Date: Mon, 18 Aug 2025 19:26:41 +0100 [thread overview]
Message-ID: <20250818192641.61f9af06@jic23-huawei> (raw)
In-Reply-To: <20250818131253.8854-2-Ioana.Risteiu@analog.com>
On Mon, 18 Aug 2025 16:12:47 +0300
Ioana Risteiu <Ioana.Risteiu@analog.com> wrote:
> Add axi_adc_num_lanes_set in the adi_axi_adc_ops structure to support
> setting number of lanes used by AXI ADC.
>
> Signed-off-by: Ioana Risteiu <Ioana.Risteiu@analog.com>
So far we only have this set for a specific compatible. Why does it
now make sense to set it for the 'generic' case? Please add something
to the patch description.
Jonathan
> ---
> drivers/iio/adc/adi-axi-adc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c
> index 2d86bb0e08a7..20bb59c24acf 100644
> --- a/drivers/iio/adc/adi-axi-adc.c
> +++ b/drivers/iio/adc/adi-axi-adc.c
> @@ -617,6 +617,7 @@ static const struct iio_backend_ops adi_axi_adc_ops = {
> .chan_status = axi_adc_chan_status,
> .interface_type_get = axi_adc_interface_type_get,
> .oversampling_ratio_set = axi_adc_oversampling_ratio_set,
> + .num_lanes_set = axi_adc_num_lanes_set,
> .debugfs_reg_access = iio_backend_debugfs_ptr(axi_adc_reg_access),
> .debugfs_print_chan_status = iio_backend_debugfs_ptr(axi_adc_debugfs_print_chan_status),
> };
next prev parent reply other threads:[~2025-08-18 18:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 13:12 [PATCH v3 0/4] Add IIO backend support for AD7779 Ioana Risteiu
2025-08-18 13:12 ` [PATCH v3 1/4] iio: adc: adi-axi-adc: add axi_adc_num_lanes_set Ioana Risteiu
2025-08-18 18:26 ` Jonathan Cameron [this message]
2025-08-18 13:12 ` [PATCH v3 2/4] dt-bindings: iio: adc: add IIO backend support Ioana Risteiu
2025-08-18 13:37 ` Krzysztof Kozlowski
2025-08-18 13:45 ` David Lechner
2025-08-18 13:12 ` [PATCH v3 3/4] iio: adc: extract setup function without backend Ioana Risteiu
2025-08-18 13:12 ` [PATCH v3 4/4] iio: adc: update ad7779 to use IIO backend Ioana Risteiu
2025-08-18 15:15 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818192641.61f9af06@jic23-huawei \
--to=jic23@kernel.org \
--cc=Ioana.Risteiu@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.nechita@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox