Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Tianma TL121BVMS07-00 panel

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2793 bytes --]

On Thu, Oct 16, 2025 at 05:50:42PM +0800, Langyan Ye wrote:
> Add device tree bindings for the Tianma TL121BVMS07-00 12.1-inch
> MIPI-DSI TFT LCD panel. The panel is based on the Ilitek IL79900A
> controller.
> 
> Signed-off-by: Langyan Ye <yelangyan@huaqin.corp-partner.google.com>
> ---
>  .../display/panel/ilitek,il79900a.yaml        | 66 +++++++++++++++++++
>  1 file changed, 66 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml
> new file mode 100644
> index 000000000000..4e3c5afd4584
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/ilitek,il79900a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ilitek IL79900a based MIPI-DSI panels
> +
> +maintainers:
> +  - Langyan Ye <yelangyan@huaqin.corp-partner.google.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - tianma,il79900a

Per the commit message, this is for a "Tianma TL121BVMS07-00 12.1-inch
MIPI-DSI TFT LCD panel". The compatible you've chosen looks like a
copy-paste mistake. Please change it to match the name of the device.

> +      - const: ilitek,il79900a
> +
> +  reg: true

Missing constraints here, right? Unlike backlight, panel-common.yaml
doesn't define this property.

pw-bot: changes-requested

> +
> +  enable-gpios:
> +    maxItems: 1
> +    description: GPIO specifier for the enable pin
> +
> +  avdd-supply:
> +    description: Positive analog voltage supply (AVDD)
> +
> +  avee-supply:
> +    description: Negative analog voltage supply (AVEE)
> +
> +  pp1800-supply:
> +    description: 1.8V logic voltage supply
> +
> +  backlight: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - enable-gpios
> +  - avdd-supply
> +  - avee-supply
> +  - pp1800-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "tianma,il79900a", "ilitek,il79900a";
> +            reg = <0>;
> +            enable-gpios = <&pio 25 0>;
> +            avdd-supply = <&reg_avdd>;
> +            avee-supply = <&reg_avee>;
> +            pp1800-supply = <&reg_pp1800>;
> +            backlight = <&backlight>;
> +        };
> +    };
> +
> +...
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]