From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jassi Brar <jassisinghbrar@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: mailbox: Add Renesas MFIS Mailbox
Date: Tue, 28 Oct 2025 09:36:32 +0100 [thread overview]
Message-ID: <20251028-pastoral-efficient-mandrill-c4e9ca@kuoka> (raw)
In-Reply-To: <87jz0fsl0u.wl-kuninori.morimoto.gx@renesas.com>
On Tue, Oct 28, 2025 at 04:33:21AM +0000, Kuninori Morimoto wrote:
> Add device tree bindings for the Renesas Multifunctional Inferface
Typo
> (MFIS) a mailbox controller.
You still have mis-ordered patches. Please organize the patch
documenting compatible (DT bindings) before their user. See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> .../bindings/mailbox/rcar,mfis-mailbox.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/rcar,mfis-mailbox.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/rcar,mfis-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/rcar,mfis-mailbox.yaml
> new file mode 100644
> index 0000000000000..8f5f3a5ea717d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/rcar,mfis-mailbox.yaml
Filename matching fallback compatible. See writing bindings.
I already asked for this and you never replied.
I will not review the rest, please implement all the comments.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-28 8:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 4:32 [PATCH v2 0/3] mailbox: renesas: Support MFIS mailbox driver Kuninori Morimoto
2025-10-28 4:32 ` [PATCH v2 1/3] mailbox: remove unneeded double quotation Kuninori Morimoto
2025-10-28 11:06 ` Wolfram Sang
2025-10-29 0:43 ` Kuninori Morimoto
2025-10-28 4:32 ` [PATCH v2 2/3] mailbox: renesas: Support MFIS mailbox driver Kuninori Morimoto
2025-11-08 20:13 ` Jassi Brar
2025-11-10 0:42 ` Kuninori Morimoto
2025-11-12 1:11 ` Kuninori Morimoto
2025-12-04 2:19 ` Jassi Brar
2025-12-04 2:33 ` Kuninori Morimoto
2026-01-05 21:49 ` Rob Herring
2026-01-05 23:52 ` Kuninori Morimoto
2026-01-18 20:22 ` Jassi Brar
2026-01-06 0:22 ` Jassi Brar
2025-10-28 4:33 ` [PATCH v2 3/3] dt-bindings: mailbox: Add Renesas MFIS Mailbox Kuninori Morimoto
2025-10-28 8:36 ` Krzysztof Kozlowski [this message]
2025-10-29 0:49 ` Kuninori Morimoto
2025-10-29 9:36 ` Geert Uytterhoeven
2025-10-29 23:17 ` Kuninori Morimoto
2025-10-30 5:38 ` Krzysztof Kozlowski
2025-10-30 5:44 ` Kuninori Morimoto
2025-10-30 5:57 ` Kuninori Morimoto
2025-10-31 4:22 ` Kuninori Morimoto
2025-10-31 7:59 ` Krzysztof Kozlowski
2025-10-28 9:12 ` Geert Uytterhoeven
2025-10-28 11:04 ` Wolfram Sang
2025-10-28 11:41 ` Wolfram Sang
2025-10-30 0:01 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028-pastoral-efficient-mandrill-c4e9ca@kuoka \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox