* [PATCH v2 1/2] dt-bindings: regulator: pca9540: add debounce timer configuration
@ 2025-11-12 16:33 Martijn de Gouw
2025-11-12 19:06 ` Conor Dooley
0 siblings, 1 reply; 2+ messages in thread
From: Martijn de Gouw @ 2025-11-12 16:33 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robin Gong
Cc: Martijn de Gouw, linux-kernel, devicetree
Make the different debounce timers configurable from the devicetree.
Depending on the board design, these have to be set different than the
default register values.
Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
---
.../regulator/nxp,pca9450-regulator.yaml | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
index a5486c36830f0..3d47390f13016 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
@@ -124,6 +124,30 @@ properties:
When WDOG_B signal is asserted a warm reset will be done instead of cold
reset.
+ nxp,pmic_on_req-on-debounce-us:
+ enum: [ 120, 20000, 100000, 750000 ]
+ description: Debounce time for PMIC_ON_REQ high.
+
+ nxp,pmic_on_req-off-debounce-us:
+ enum: [ 120, 2000 ]
+ description: Debounce time for PMIC_ON_REQ is asserted low
+
+ nxp,power-on-step-ms:
+ enum: [ 1, 2, 4, 8]
+ description: Time step configuration during power on sequence
+
+ nxp,power-down-step-ms:
+ enum: [ 2, 4, 8, 16 ]
+ description: Time step configuration during power down sequence
+
+ nxp,restart-ms:
+ enum: [ 250, 500 ]
+ description: Time to stay off regulators during Cold reset
+
+ npx,pmic_rst_b-debounce-ms:
+ enum: [ 10, 50, 100, 500, 1000, 2000, 4000, 8000 ]
+ description: PMIC_RST_B debounce time
+
required:
- compatible
- reg
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: regulator: pca9540: add debounce timer configuration
2025-11-12 16:33 [PATCH v2 1/2] dt-bindings: regulator: pca9540: add debounce timer configuration Martijn de Gouw
@ 2025-11-12 19:06 ` Conor Dooley
0 siblings, 0 replies; 2+ messages in thread
From: Conor Dooley @ 2025-11-12 19:06 UTC (permalink / raw)
To: Martijn de Gouw
Cc: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robin Gong, linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 2086 bytes --]
On Wed, Nov 12, 2025 at 05:33:08PM +0100, Martijn de Gouw wrote:
> Make the different debounce timers configurable from the devicetree.
> Depending on the board design, these have to be set different than the
> default register values.
>
> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
> ---
> .../regulator/nxp,pca9450-regulator.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> index a5486c36830f0..3d47390f13016 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> @@ -124,6 +124,30 @@ properties:
> When WDOG_B signal is asserted a warm reset will be done instead of cold
> reset.
>
> + nxp,pmic_on_req-on-debounce-us:
> + enum: [ 120, 20000, 100000, 750000 ]
> + description: Debounce time for PMIC_ON_REQ high.
I left some comments on v1, one a question and one a request for a
change. Please go take a look. Since you'll need a v3
pw-bot: changes-requested
(Please also give a bit more time between revisions for people to go
through their mail queues)
> +
> + nxp,pmic_on_req-off-debounce-us:
> + enum: [ 120, 2000 ]
> + description: Debounce time for PMIC_ON_REQ is asserted low
> +
> + nxp,power-on-step-ms:
> + enum: [ 1, 2, 4, 8]
> + description: Time step configuration during power on sequence
> +
> + nxp,power-down-step-ms:
> + enum: [ 2, 4, 8, 16 ]
> + description: Time step configuration during power down sequence
> +
> + nxp,restart-ms:
> + enum: [ 250, 500 ]
> + description: Time to stay off regulators during Cold reset
> +
> + npx,pmic_rst_b-debounce-ms:
> + enum: [ 10, 50, 100, 500, 1000, 2000, 4000, 8000 ]
> + description: PMIC_RST_B debounce time
> +
> required:
> - compatible
> - reg
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-12 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-12 16:33 [PATCH v2 1/2] dt-bindings: regulator: pca9540: add debounce timer configuration Martijn de Gouw
2025-11-12 19:06 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox