[PATCH v6 0/2] iio: pressure: abp2030pa: cleanup

[PATCH v6 0/2] iio: pressure: abp2030pa: cleanup

[Petre Rodan]

Fix one typo within a Kconfig description and remove redundant error message
if devm_request_irq() fails.

This cleanup series is now based on the testing branch as requested by Jonathan.

- Link to v5: https://lore.kernel.org/r/20260103-honeywell_abp2_driver-v5-0-0435afcf306d@subdimension.ro

Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
Petre Rodan (2):
      iio: pressure: abp2030pa: fix typo in Kconfig description
      iio: pressure: abp2030pa: remove error message

 drivers/iio/pressure/Kconfig     | 2 +-
 drivers/iio/pressure/abp2030pa.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: e0bc6d7e258486c10bb11e31fd4421c134063b1d
change-id: 20251122-honeywell_abp2_driver-9c796ef0c4b2

Best regards,
-- 
Petre Rodan <petre.rodan@subdimension.ro>

[PATCH v6 1/2] iio: pressure: abp2030pa: fix typo in Kconfig description

[Petre Rodan]

Replace "I2C" with "SPI" in the SPI module description.

Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
 drivers/iio/pressure/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
index 0d25842aa414..838a8340c4c0 100644
--- a/drivers/iio/pressure/Kconfig
+++ b/drivers/iio/pressure/Kconfig
@@ -38,7 +38,7 @@ config ABP2030PA_SPI
 	depends on SPI_MASTER
 	select ABP2030PA
 	help
-	  Say Y here to build I2C bus support for the Honeywell ABP2
+	  Say Y here to build SPI bus support for the Honeywell ABP2
 	  series pressure and temperature digital sensor.
 
 	  To compile this driver as a module, choose M here: the module

-- 
2.52.0

[PATCH v6 2/2] iio: pressure: abp2030pa: remove error message

[Petre Rodan]

Do not print redundant error message if devm_request_irq() fails.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
 drivers/iio/pressure/abp2030pa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
index be11e28208ec..4ca056a73cef 100644
--- a/drivers/iio/pressure/abp2030pa.c
+++ b/drivers/iio/pressure/abp2030pa.c
@@ -523,7 +523,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
 		ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
 				       dev_name(dev), data);
 		if (ret)
-			return dev_err_probe(dev, ret, "request irq %d failed\n", data->irq);
+			return ret;
 	}
 
 	ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,

-- 
2.52.0

Re: [PATCH v6 2/2] iio: pressure: abp2030pa: remove error message

[Andy Shevchenko]

On Wed, Jan 14, 2026 at 9:52 AM Petre Rodan <petre.rodan@subdimension.ro> wrote:
>
> Do not print redundant error message if devm_request_irq() fails.

the duplicate

(It's not redundant, it's duplicate because that API prints something
very similar.)

P.S. Do not send a new version for this, I hope Jonathan can tweak
this small detail whilst applying.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v6 1/2] iio: pressure: abp2030pa: fix typo in Kconfig description

[Jonathan Cameron]

On Wed, 14 Jan 2026 09:51:37 +0200
Petre Rodan <petre.rodan@subdimension.ro> wrote:

> Replace "I2C" with "SPI" in the SPI module description.
> 
> Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
I dropped the fixes tag as we wouldn't normally bother for a help text
typo (+ it might be a pain if I do have to rebase my tree for something
nasty that I haven't noticed yet).

Applied.
> ---
>  drivers/iio/pressure/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index 0d25842aa414..838a8340c4c0 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -38,7 +38,7 @@ config ABP2030PA_SPI
>  	depends on SPI_MASTER
>  	select ABP2030PA
>  	help
> -	  Say Y here to build I2C bus support for the Honeywell ABP2
> +	  Say Y here to build SPI bus support for the Honeywell ABP2
>  	  series pressure and temperature digital sensor.
>  
>  	  To compile this driver as a module, choose M here: the module
> 

Re: [PATCH v6 2/2] iio: pressure: abp2030pa: remove error message

[Jonathan Cameron]

On Wed, 14 Jan 2026 09:55:22 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Jan 14, 2026 at 9:52 AM Petre Rodan <petre.rodan@subdimension.ro> wrote:
> >
> > Do not print redundant error message if devm_request_irq() fails.  
> 
> the duplicate
I went with "a duplicate" as it seemed to read better to my ear.

Tweaked and applied.

Thanks,

Jonathan

> 
> (It's not redundant, it's duplicate because that API prints something
> very similar.)
> 
> P.S. Do not send a new version for this, I hope Jonathan can tweak
> this small detail whilst applying.
>