From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Weiss <luca@lucaweiss.eu>
Cc: ~postmarketos/upstreaming@lists.sr.ht, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
phone-devel@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add mt8516-syscfg
Date: Sat, 7 Feb 2026 11:51:19 +0100 [thread overview]
Message-ID: <20260207-tricky-strange-swan-6f11b0@quoll> (raw)
In-Reply-To: <20260206-mt8516-syscfg-syscon-v1-1-96dcb37acdb4@lucaweiss.eu>
On Fri, Feb 06, 2026 at 11:20:48AM +0100, Luca Weiss wrote:
> Document the Mediatek mt8516-syscfg.
Which is what? What is syscfg block?
>
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e57add2bacd3..a67699f1faee 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -91,6 +91,7 @@ select:
> - mediatek,mt8135-pctl-b-syscfg
> - mediatek,mt8173-pctl-a-syscfg
> - mediatek,mt8365-syscfg
> + - mediatek,mt8516-syscfg
Why aren't you placing it with all others mediatek,mt8516 syscons?
Why this is so generically called "syscfg", completely not looking like
a real name from datasheet unlike the others in this device.
You have entire commit msg to explain that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-07 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 10:20 [PATCH 0/2] Fix syscfg-pctl compatible for MT8516 Luca Weiss
2026-02-06 10:20 ` [PATCH 1/2] dt-bindings: mfd: syscon: Add mt8516-syscfg Luca Weiss
2026-02-07 10:51 ` Krzysztof Kozlowski [this message]
2026-02-09 11:34 ` AngeloGioacchino Del Regno
2026-02-09 20:45 ` Luca Weiss
2026-02-10 10:51 ` AngeloGioacchino Del Regno
2026-02-06 10:20 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: fix syscfg-pctl compatible Luca Weiss
2026-02-07 10:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260207-tricky-strange-swan-6f11b0@quoll \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luca@lucaweiss.eu \
--cc=matthias.bgg@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox