Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add mt8516-syscfg

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 09/02/26 21:45, Luca Weiss ha scritto:
> Hi AngeloGioacchino,
> 
> On 09-02-2026 12:34, AngeloGioacchino Del Regno wrote:
>> Il 07/02/26 11:51, Krzysztof Kozlowski ha scritto:
>>> On Fri, Feb 06, 2026 at 11:20:48AM +0100, Luca Weiss wrote:
>>>> Document the Mediatek mt8516-syscfg.
>>>
>>> Which is what? What is syscfg block?
>>>
>>
>> Not sure this is really a SYSCFG block.
>>
>> This should be a GPIO controller range, which is split between IOCFG and EINT.
>> Now, the legacy drivers are declaring the EINT iospace in the pinctrl node, and
>> getting the GPIO controller (IOCFG) iospace from a regmap.
>>
>> I don't have any board with MT8516... but well, the really-right-thing to do
>> would be to migrate that SoC off of the legacy driver, to the new-style one
>> that *properly* takes two iospaces:
>> "base" -> (0x10005000)
>> "eint" -> (0x1000b000)
>>
>> Luca, if you've got such a board, could you please try to migrate this SoC out
>> of the improper (but working good) driver and bindings?
>>
>> If not... well, I think this block is IOCFG, not SYSCFG...
> 
> Thanks for the suggestions. This is essentially my first Mediatek patch and while 
> I'd say I have a good understanding of Qualcomm SoCs, Mediatek is very different, 
> so I've got no clue about anything here really ;)
> 
> I'll try to decipher your comment and see what I can do about it, hopefully soon. 
> Thanks!
> 

Oh, okay. You want to check mt6795.dtsi - that's a SoC that has "more or less" the
same generation of GPIO Controller IP as MT8516.

Also, useless to say, drivers/pinctrl/mediatek ... there's a pinctrl-moore and a
pinctrl-paris; your SoC *should* be paris, but I don't really know - you want to
definitely check if the register layout matches between the old-legacy-deprecated
driver and the Paris IP.

Check a bit; should you have any question, either reply here or shoot me an email,
I'll do anything I can (though probably with late replies, as I'm usually a bit
busy with work - but no worries about disturbing in any way!) to clarify things
for you.

Cheers,
Angelo

> Regards
> Luca
> 
>>
>> Cheers,
>> Angelo
>>
>>>>
>>>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>>>> ---
>>>>   Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/ 
>>>> Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> index e57add2bacd3..a67699f1faee 100644
>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> @@ -91,6 +91,7 @@ select:
>>>>             - mediatek,mt8135-pctl-b-syscfg
>>>>             - mediatek,mt8173-pctl-a-syscfg
>>>>             - mediatek,mt8365-syscfg
>>>> +          - mediatek,mt8516-syscfg
>>>
>>> Why aren't you placing it with all others mediatek,mt8516 syscons?
>>>
>>> Why this is so generically called "syscfg", completely not looking like
>>> a real name from datasheet unlike the others in this device.
>>>
>>> You have entire commit msg to explain that.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>>
>