From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Michael Hennerich" <michael.hennerich@analog.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"David Lechner" <dlechner@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Petre Rodan" <petre.rodan@subdimension.ro>,
"Jorge Marques" <jorge.marques@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] iio: accel: adxl372: introduce chip_info structure
Date: Sat, 21 Mar 2026 11:13:39 +0000 [thread overview]
Message-ID: <20260321111339.0704b83c@jic23-huawei> (raw)
In-Reply-To: <20260321100729.2440-2-antoniu.miclaus@analog.com>
On Sat, 21 Mar 2026 12:04:56 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Introduce a chip_info structure to parameterize device-specific
> properties such as ODR/bandwidth frequency tables, activity/inactivity
> timer scale factors, and the maximum ODR value. This refactors the
> driver to use chip_info lookups instead of hardcoded values, preparing
> the driver to support multiple device variants.
>
> The sampling_frequency and filter_low_pass_3db_frequency available
> attributes are switched from custom sysfs callbacks to read_avail()
> based handling via info_mask_shared_by_type_available. This enforces
> consistent formatting through the IIO framework and makes the values
> accessible to in-kernel consumers.
I'd slightly have preferred that as a precursor patch, but never mind
it's not too bad in here. So this is more of a comment for 'next
time' than anything to bother fixing for this series.
>
> The SPI/I2C probe functions are updated to pass a chip_info pointer
> instead of a device name string.
>
> No functional change intended.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
next prev parent reply other threads:[~2026-03-21 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 10:04 [PATCH v4 0/4] iio: accel: adxl372: add ADXL371 support Antoniu Miclaus
2026-03-21 10:04 ` [PATCH v4 1/4] iio: accel: adxl372: introduce chip_info structure Antoniu Miclaus
2026-03-21 11:13 ` Jonathan Cameron [this message]
2026-03-21 10:04 ` [PATCH v4 2/4] dt-bindings: iio: accel: adi,adxl372: add ADXL371 compatible Antoniu Miclaus
2026-03-21 10:04 ` [PATCH v4 3/4] iio: accel: adxl372: factor out buffer and trigger setup Antoniu Miclaus
2026-03-21 11:18 ` Jonathan Cameron
2026-03-21 10:04 ` [PATCH v4 4/4] iio: accel: adxl372: add support for ADXL371 Antoniu Miclaus
2026-03-21 11:25 ` [PATCH v4 0/4] iio: accel: adxl372: add ADXL371 support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321111339.0704b83c@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jorge.marques@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox