Re: [PATCH v4 0/4] iio: accel: adxl372: add ADXL371 support

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 21 Mar 2026 12:04:55 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Add support for the Analog Devices ADXL371 3-axis, +-200g MEMS
> accelerometer to the existing ADXL372 IIO driver. The ADXL371 shares
> the same register map as the ADXL372 but differs in ODR/bandwidth
> values, timer scale factors, and has a known silicon anomaly (er001)
> that prevents reliable FIFO operation.

Applied with minor line break tweak in patch 3.
Looks to me like you've addressed Andy's comments and there was nothing
else outstanding. I'm applying this without waiting to see if Andy
has any last feedback mostly to make life a bit easier but cutting down
the number of series in flight!  

For now pushed out as testing, as such (for now) I'm fine tweaking, dropping
or adding tags if more feedback does come in.

Thanks,

Jonathan
> 
> Changes in v4:
>  - [Patch 1/4] Reformat info_mask_shared_by_type to use consistent
>    multi-line style matching info_mask_shared_by_type_available.
>  - [Patch 1/4] Drop trailing comma from ADXL372_ODR_NUM enum
>    terminator.
>  - [Patch 1/4] Drop redundant NULL checks for chip_info in SPI/I2C
>    probe functions since match data is always provided.
>  - [Patch 3/4] Use 'if (ret)' instead of 'if (ret < 0)' for
>    devm_iio_trigger_register() and devm_iio_triggered_buffer_setup_ext()
>    return checks in adxl372_buffer_setup().
>  - [Patch 4/4] Drop trailing comma from ADXL371_ODR_NUM enum
>    terminator.
> 
> Antoniu Miclaus (4):
>   iio: accel: adxl372: introduce chip_info structure
>   dt-bindings: iio: accel: adi,adxl372: add ADXL371 compatible
>   iio: accel: adxl372: factor out buffer and trigger setup
>   iio: accel: adxl372: add support for ADXL371
> 
>  .../bindings/iio/accel/adi,adxl372.yaml       |   9 +-
>  MAINTAINERS                                   |   5 +-
>  drivers/iio/accel/Kconfig                     |  12 +-
>  drivers/iio/accel/adxl372.c                   | 300 +++++++++++-------
>  drivers/iio/accel/adxl372.h                   |  20 +-
>  drivers/iio/accel/adxl372_i2c.c               |  17 +-
>  drivers/iio/accel/adxl372_spi.c               |  17 +-
>  7 files changed, 244 insertions(+), 136 deletions(-)
>