Re: [PATCH v6 03/12] iio: dac: ds4424: sort headers alphabetically

Re: [PATCH v6 03/12] iio: dac: ds4424: sort headers alphabetically

[Jonathan Cameron]

On Tue, 10 Feb 2026 14:51:01 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> Sort the header inclusions alphabetically. This improves readability and
> simplifies adding new includes in the future.
> 
> Group subsystem-specific headers (linux/iio/*) separately at the end
> to clarify subsystem context.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

I applied this one by hand as iio/consumer.h isn't used and another
series had removed it in the meantime.

Thanks,

Jonathan

> ---
> changes v6:
> - no changes
> changes v5:
> - no changes
> changes v4:
> - no changes
> changes v3:
> - Keep linux/iio/* headers in a separate group at the end of the includes.
> changes v2:
> - new patch
> ---
>  drivers/iio/dac/ds4424.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 36286e4923af..c03051dc763e 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -6,16 +6,17 @@
>   */
>  
>  #include <linux/bits.h>
> +#include <linux/delay.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/i2c.h>
>  #include <linux/regulator/consumer.h>
> -#include <linux/err.h>
> -#include <linux/delay.h>
> -#include <linux/iio/iio.h>
> +
> +#include <linux/iio/consumer.h>
>  #include <linux/iio/driver.h>
> +#include <linux/iio/iio.h>
>  #include <linux/iio/machine.h>
> -#include <linux/iio/consumer.h>
>  
>  #define DS4422_MAX_DAC_CHANNELS		2
>  #define DS4424_MAX_DAC_CHANNELS		4

Re: [PATCH v6 00/12] iio: dac: ds4424: add DS4402/DS4404 support and scale

[Jonathan Cameron]

On Thu, 26 Feb 2026 10:08:33 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Thu, 26 Feb 2026 09:42:20 +0100
> Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> 
> > Hi Jonathan,
> > 
> > Should I resend this patch series?  
> No need.   For future reference I use patchwork.kernel.org to track
> status of series.   This one is sat there because I need to do a pull
> request for the precursor fix (which I'll do shortly).  That then needs
> to loop around into a suitable upstream tree before I can pick this
> series up on top of it.
> 
I merge 7.0-rc4 into the testing branch of iio.git and applied this on top.
If the build bots are happy I'll push that out as togreg in the next few days.
A little bit of fuzz in a few patches but otherwise it went on pretty cleanly.

Please take a quick look to make sure I didn't mess anything up.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> > 
> > On Tue, Feb 10, 2026 at 02:50:58PM +0100, Oleksij Rempel wrote:  
> > > changes v6:
> > > - rebase on top of iio/fixes-togreg
> > > - drop "iio: dac: ds4424: reject -128 RAW value", already included
> > > 
> > > This series extends the ds4424 IIO DAC driver and its devicetree binding
> > > to support the DS4402 and DS4404 current DAC variants.
> > > 
> > > DS440x devices share the same register map as DS442x but use a different
> > > resolution (5-bit vs 7-bit) and a different full-scale current formula.
> > > The full-scale current depends on external Rfs resistors connected to
> > > the FS pins, so a new optional DT property is added to provide the
> > > per-channel Rfs values and allow the driver to report a correct IIO
> > > SCALE (mA/step).
> > > 
> > > While adding DS440x support, a few related issues were addressed:
> > > - Port to regmap
> > > - Reject -128 in RAW writes on DS442x, which cannot be represented with
> > >   sign-magnitude encoding and could silently program an unintended
> > >   output.
> > > - Preserve preconfigured values on probe.
> > > - Ratelimit read error logging and use device context.
> > > 
> > > David Jander (1):
> > >   iio: dac: ds4424: add DS4402/DS4404 device IDs
> > > 
> > > Oleksij Rempel (11):
> > >   iio: dac: ds4424: refactor raw access to use bitwise operations
> > >   iio: dac: ds4424: ratelimit read errors and use device context
> > >   iio: dac: ds4424: sort headers alphabetically
> > >   iio: dac: ds4424: rename iio_info struct to avoid ambiguity
> > >   iio: dac: ds4424: use device match data for chip info
> > >   iio: dac: ds4424: use fsleep() instead of usleep_range()
> > >   dt-bindings: iio: dac: maxim,ds4424: add ds4402/ds4404
> > >   iio: dac: ds4424: support per-variant output range limits
> > >   iio: dac: ds4424: convert to regmap
> > >   dt-bindings: iio: dac: maxim,ds4424: add maxim,rfs-ohms property
> > >   iio: dac: ds4424: add Rfs-based scale and per-variant limits
> > > 
> > >  .../bindings/iio/dac/maxim,ds4424.yaml        |  42 +-
> > >  drivers/iio/dac/Kconfig                       |   1 +
> > >  drivers/iio/dac/ds4424.c                      | 375 ++++++++++++------
> > >  3 files changed, 287 insertions(+), 131 deletions(-)
> > > 
> > > --
> > > 2.47.3
> > > 
> > > 
> > >     
> >   
> 
> 

Re: [PATCH v6 00/12] iio: dac: ds4424: add DS4402/DS4404 support and scale

[Oleksij Rempel]

On Sun, Mar 22, 2026 at 12:45:39PM +0000, Jonathan Cameron wrote:
> On Thu, 26 Feb 2026 10:08:33 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Thu, 26 Feb 2026 09:42:20 +0100
> > Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> > 
> > > Hi Jonathan,
> > > 
> > > Should I resend this patch series?  
> > No need.   For future reference I use patchwork.kernel.org to track
> > status of series.   This one is sat there because I need to do a pull
> > request for the precursor fix (which I'll do shortly).  That then needs
> > to loop around into a suitable upstream tree before I can pick this
> > series up on top of it.
> > 
> I merge 7.0-rc4 into the testing branch of iio.git and applied this on top.
> If the build bots are happy I'll push that out as togreg in the next few days.
> A little bit of fuzz in a few patches but otherwise it went on pretty cleanly.
> 
> Please take a quick look to make sure I didn't mess anything up.

LGTM. Thank you!

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |