public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
To: Bryan O'Donoghue <bod@kernel.org>,
	Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Stefan Schmidt <stefan.schmidt@linaro.org>,
	Hans Verkuil <hverkuil@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux.dev,
	Vishnu Reddy <busanna.reddy@oss.qualcomm.com>,
	stable@vger.kernel.org
Subject: [PATCH 06/11] media: iris: Fix VM count passed to firmware
Date: Tue, 14 Apr 2026 10:30:02 +0530	[thread overview]
Message-ID: <20260414-glymur-v1-6-7d3d1cf57b16@oss.qualcomm.com> (raw)
In-Reply-To: <20260414-glymur-v1-0-7d3d1cf57b16@oss.qualcomm.com>

On Glymur, firmware interprets the value written to CPU_CS_SCIACMDARG3 as
the number of virtual machines (VMs) and internally adds 1 to it. Writing
1 causes firmware to treat it as 2 VMs. Since only one VM is required,
remove this write to leave the register at its reset value of 0. This does
not affect other platforms as only Glymur firmware uses this register,
earlier platform firmwares ignore it.

Fixes: abf5bac63f68a ("media: iris: implement the boot sequence of the firmware")
Cc: stable@vger.kernel.org
Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
---
 drivers/media/platform/qcom/iris/iris_vpu_common.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c
index 548e5f1727fd..bfd1e762c38e 100644
--- a/drivers/media/platform/qcom/iris/iris_vpu_common.c
+++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c
@@ -78,7 +78,6 @@ int iris_vpu_boot_firmware(struct iris_core *core)
 	iris_vpu_setup_ucregion_memory_map(core);
 
 	writel(ctrl_init, core->reg_base + CTRL_INIT);
-	writel(0x1, core->reg_base + CPU_CS_SCIACMDARG3);
 
 	while (!ctrl_status && count < max_tries) {
 		ctrl_status = readl(core->reg_base + CTRL_STATUS);

-- 
2.34.1


  parent reply	other threads:[~2026-04-14  5:01 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  4:59 [PATCH 00/11] media: iris: Add support for glymur platform Vishnu Reddy
2026-04-14  4:59 ` [PATCH 01/11] dt-bindings: media: qcom,glymur-iris: Add glymur video codec Vishnu Reddy
2026-04-14  7:25   ` Krzysztof Kozlowski
2026-04-14  9:46     ` Vishnu Reddy
2026-04-14  4:59 ` [PATCH 02/11] media: iris: Add iris vpu bus support and register it with iommu_buses Vishnu Reddy
2026-04-14 15:14   ` Dmitry Baryshkov
     [not found]     ` <5dee6da0-9170-d9e0-5ff7-f8436331c6a9@oss.qualcomm.com>
2026-04-17 14:59       ` Vishnu Reddy
2026-04-17 18:19         ` Dmitry Baryshkov
2026-04-20 14:02           ` Vishnu Reddy
2026-04-20 17:56             ` Dmitry Baryshkov
2026-04-14  4:59 ` [PATCH 03/11] media: iris: Add context bank hooks for platform specific initialization Vishnu Reddy
2026-04-14 15:16   ` Dmitry Baryshkov
2026-04-17 15:03     ` Vishnu Reddy
2026-04-14  5:00 ` [PATCH 04/11] media: iris: Add helper to create a context bank device on iris vpu bus Vishnu Reddy
2026-04-14 15:18   ` Dmitry Baryshkov
2026-04-17 15:19     ` Vishnu Reddy
2026-04-17 18:23       ` Dmitry Baryshkov
2026-04-20 14:03         ` Vishnu Reddy
2026-04-20 17:56           ` Dmitry Baryshkov
2026-04-22  6:19             ` Vishnu Reddy
2026-04-14  5:00 ` [PATCH 05/11] media: iris: Enable Secure PAS support with IOMMU managed by Linux Vishnu Reddy
2026-04-14  6:31   ` Mukesh Ojha
2026-04-14  9:33     ` Mukesh Ojha
2026-04-15  7:36     ` Mukesh Ojha
2026-04-15  7:41       ` Mukesh Ojha
2026-04-17 15:20     ` Vishnu Reddy
2026-04-14 14:09   ` Konrad Dybcio
2026-04-17 15:27     ` Vishnu Reddy
2026-04-14  5:00 ` Vishnu Reddy [this message]
2026-04-14  6:33   ` [PATCH 06/11] media: iris: Fix VM count passed to firmware Mukesh Ojha
2026-04-17 15:28     ` Vishnu Reddy
2026-04-14  9:29   ` Konrad Dybcio
2026-04-17 14:35     ` Vishnu Reddy
2026-04-14 15:20   ` Dmitry Baryshkov
2026-04-17 15:29     ` Vishnu Reddy
2026-04-22  7:37   ` Vikash Garodia
2026-04-14  5:00 ` [PATCH 07/11] media: iris: Rename clock and power domain macros to use vcodec prefix Vishnu Reddy
2026-04-14  6:38   ` Mukesh Ojha
2026-04-14  7:20     ` Vishnu Reddy
2026-04-14  5:00 ` [PATCH 08/11] media: iris: Add power sequence for Glymur Vishnu Reddy
2026-04-14  9:49   ` Konrad Dybcio
2026-04-17 16:04     ` Vishnu Reddy
2026-04-14 15:23   ` Dmitry Baryshkov
2026-04-14  5:00 ` [PATCH 09/11] media: iris: Add support to select core for dual core platforms Vishnu Reddy
2026-04-14  9:51   ` Konrad Dybcio
2026-04-17 15:36     ` Vishnu Reddy
2026-04-14 16:02   ` Dmitry Baryshkov
2026-04-22  6:04     ` Vikash Garodia
2026-04-14  5:00 ` [PATCH 10/11] media: iris: Add platform data for glymur Vishnu Reddy
2026-04-14 16:05   ` Dmitry Baryshkov
2026-04-17 15:52     ` Vishnu Reddy
2026-04-14  5:00 ` [PATCH 11/11] arm64: dts: qcom: glymur: Add iris video node Vishnu Reddy
2026-04-14 14:10   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260414-glymur-v1-6-7d3d1cf57b16@oss.qualcomm.com \
    --to=busanna.reddy@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=andersson@kernel.org \
    --cc=bod@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=hverkuil@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=stefan.schmidt@linaro.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox