* [PATCH v2 1/4] riscv: dts: spacemit: k1-bananapi-f3: Add vcc5v0_sys regulator for Banana Pi F3
2026-05-02 5:18 [PATCH v2 0/4] spacemit: k1-bananapi-f3: Fix the power source of USB3 nodes Anand Moon
@ 2026-05-02 5:18 ` Anand Moon
2026-05-02 5:18 ` [PATCH v2 2/4] riscv: dts: spacemit: k1-bananapi-f3: Update USB regulator on onboard usb and label Anand Moon
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Anand Moon @ 2026-05-02 5:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, open list
Cc: Anand Moon, Han Gao, Ze Huang, Chukun Pan
Define the system 5V fixed regulator (vcc5v0_sys) supplied by the
DC input. As per the schematics, vcc5v0_sys is the input power source
for the VCC5V0_HUB and 5V_VBUS reglators. Update these regulators
to correctly reference vcc5v0_sys as their parent (vin-supply).
Cc: Han Gao <gaohan@iscas.ac.cn>
Cc: Ze Huang <huang.ze@linux.dev>
Cc: Chukun Pan <amadeus@jmu.edu.cn>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
index 5790d927b93d..9727ecdd9f6b 100644
--- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
@@ -50,6 +50,16 @@ reg_dc_in: regulator-dc-in-12v {
regulator-always-on;
};
+ reg_vcc5v0_sys: regulator-vcc5v0-sys {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_sys";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ vin-supply = <®_dc_in>;
+ };
+
reg_vcc_4v: regulator-vcc-4v {
compatible = "regulator-fixed";
regulator-name = "vcc_4v";
@@ -66,6 +76,7 @@ regulator-usb3-vbus-5v {
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
regulator-always-on;
+ vin-supply = <®_vcc5v0_sys>;
gpio = <&gpio K1_GPIO(97) GPIO_ACTIVE_HIGH>;
enable-active-high;
};
@@ -75,6 +86,7 @@ usb3_hub_5v: regulator-usb3-hub-5v {
regulator-name = "USB30_HUB";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
+ vin-supply = <®_vcc5v0_sys>;
gpio = <&gpio K1_GPIO(123) GPIO_ACTIVE_HIGH>;
enable-active-high;
};
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 2/4] riscv: dts: spacemit: k1-bananapi-f3: Update USB regulator on onboard usb and label
2026-05-02 5:18 [PATCH v2 0/4] spacemit: k1-bananapi-f3: Fix the power source of USB3 nodes Anand Moon
2026-05-02 5:18 ` [PATCH v2 1/4] riscv: dts: spacemit: k1-bananapi-f3: Add vcc5v0_sys regulator for Banana Pi F3 Anand Moon
@ 2026-05-02 5:18 ` Anand Moon
2026-05-02 5:18 ` [PATCH v2 3/4] riscv: dts: spacemit: k1-bananapi-f3: Correct USB hub power hierarchy Anand Moon
2026-05-02 5:18 ` [PATCH v2 4/4] riscv: dts: spacemit: k1-bananapi-f3: Add vin-supply for PCIe 3.3V regulator Anand Moon
3 siblings, 0 replies; 5+ messages in thread
From: Anand Moon @ 2026-05-02 5:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, open list
Cc: Anand Moon, Han Gao, Ze Huang, Chukun Pan
Update the USB regulator labels to align with the board schematics and
power hierarchy. This change renames the regulator to reg_5v_vbus and
its name to 5V_VBUS. Additionally, it fixes the vdd-supply references
for both the USB 2.0 and 3.0 hub nodes to ensure they correctly point
to the 5V_VBUS input source as per the board schematics.
Cc: Han Gao <gaohan@iscas.ac.cn>
Cc: Ze Huang <huang.ze@linux.dev>
Cc: Chukun Pan <amadeus@jmu.edu.cn>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
index 9727ecdd9f6b..c35f4763c800 100644
--- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
@@ -70,9 +70,9 @@ reg_vcc_4v: regulator-vcc-4v {
vin-supply = <®_dc_in>;
};
- regulator-usb3-vbus-5v {
+ reg_5v_vbus: regulator-usb3-vbus-5v {
compatible = "regulator-fixed";
- regulator-name = "USB30_VBUS";
+ regulator-name = "5V_VBUS";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
regulator-always-on;
@@ -366,7 +366,7 @@ &usb_dwc3 {
hub_2_0: hub@1 {
compatible = "usb2109,2817";
reg = <0x1>;
- vdd-supply = <&usb3_hub_5v>;
+ vdd-supply = <®_5v_vbus>;
peer-hub = <&hub_3_0>;
reset-gpios = <&gpio K1_GPIO(124) GPIO_ACTIVE_LOW>;
};
@@ -374,7 +374,7 @@ hub_2_0: hub@1 {
hub_3_0: hub@2 {
compatible = "usb2109,817";
reg = <0x2>;
- vdd-supply = <&usb3_hub_5v>;
+ vdd-supply = <®_5v_vbus>;
peer-hub = <&hub_2_0>;
reset-gpios = <&gpio K1_GPIO(124) GPIO_ACTIVE_LOW>;
};
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 3/4] riscv: dts: spacemit: k1-bananapi-f3: Correct USB hub power hierarchy
2026-05-02 5:18 [PATCH v2 0/4] spacemit: k1-bananapi-f3: Fix the power source of USB3 nodes Anand Moon
2026-05-02 5:18 ` [PATCH v2 1/4] riscv: dts: spacemit: k1-bananapi-f3: Add vcc5v0_sys regulator for Banana Pi F3 Anand Moon
2026-05-02 5:18 ` [PATCH v2 2/4] riscv: dts: spacemit: k1-bananapi-f3: Update USB regulator on onboard usb and label Anand Moon
@ 2026-05-02 5:18 ` Anand Moon
2026-05-02 5:18 ` [PATCH v2 4/4] riscv: dts: spacemit: k1-bananapi-f3: Add vin-supply for PCIe 3.3V regulator Anand Moon
3 siblings, 0 replies; 5+ messages in thread
From: Anand Moon @ 2026-05-02 5:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, open list
Cc: Anand Moon, Han Gao, Ze Huang, Chukun Pan
Link the usb3_hub_5v regulator to the USB controller’s vbus-supply to
ensure the USB 3.0 stack is properly powered as per the schematics.
In addition, align the USB hub regulator with the board schematics
by renaming it to VCC5V0_HUB and marking it as regulator-always-on
to maintain power stability.
Cc: Han Gao <gaohan@iscas.ac.cn>
Cc: Ze Huang <huang.ze@linux.dev>
Cc: Chukun Pan <amadeus@jmu.edu.cn>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
index c35f4763c800..3dbdf53b6d8e 100644
--- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
@@ -83,9 +83,10 @@ reg_5v_vbus: regulator-usb3-vbus-5v {
usb3_hub_5v: regulator-usb3-hub-5v {
compatible = "regulator-fixed";
- regulator-name = "USB30_HUB";
+ regulator-name = "VCC5V0_HUB";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
+ regulator-always-on;
vin-supply = <®_vcc5v0_sys>;
gpio = <&gpio K1_GPIO(123) GPIO_ACTIVE_HIGH>;
enable-active-high;
@@ -361,6 +362,7 @@ &usb_dwc3 {
dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
+ vbus-supply = <&usb3_hub_5v>;
status = "okay";
hub_2_0: hub@1 {
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 4/4] riscv: dts: spacemit: k1-bananapi-f3: Add vin-supply for PCIe 3.3V regulator
2026-05-02 5:18 [PATCH v2 0/4] spacemit: k1-bananapi-f3: Fix the power source of USB3 nodes Anand Moon
` (2 preceding siblings ...)
2026-05-02 5:18 ` [PATCH v2 3/4] riscv: dts: spacemit: k1-bananapi-f3: Correct USB hub power hierarchy Anand Moon
@ 2026-05-02 5:18 ` Anand Moon
3 siblings, 0 replies; 5+ messages in thread
From: Anand Moon @ 2026-05-02 5:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, open list
Cc: Anand Moon, Han Gao, Ze Huang, Chukun Pan
The PCIe 3.3V fixed regulator node (pcie_vcc_3v3) lacked a parent
supply reference. Wire it to the 5V system rail (reg_vcc5v0_sys)
via the vin-supply property to reflect the actual board power tree.
This ensures correct regulator hierarchy in DTS and allows drivers
to resolve supply dependencies cleanly during probe.
Cc: Han Gao <gaohan@iscas.ac.cn>
Cc: Ze Huang <huang.ze@linux.dev>
Cc: Chukun Pan <amadeus@jmu.edu.cn>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2: new patch in this series.
---
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
index 3dbdf53b6d8e..6c06480ba100 100644
--- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
@@ -39,6 +39,7 @@ pcie_vcc_3v3: regulator-pcie-vcc3v3 {
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-always-on;
+ vin-supply = <®_vcc5v0_sys>;
};
reg_dc_in: regulator-dc-in-12v {
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread