* [PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible
@ 2026-05-04 7:13 Monish Chunara
2026-05-06 8:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Monish Chunara @ 2026-05-04 7:13 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Bjorn Andersson, Konrad Dybcio, linux-mmc, devicetree,
linux-kernel, Nitin Rawat, Pradeep Pragallapati, Komal Bajaj,
Monish Chunara
Add the MSM SDHCI compatible name to support both eMMC and SD card for
Shikra, which uses 'shikra' as the fallback SoC.
The SDHCI controller on Shikra is based on MSM SDHCI v5 IP. Hence,
document the compatible with "qcom,sdhci-msm-v5" as the fallback.
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 695a95e8f35d..60dc6b0caa21 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -62,6 +62,7 @@ properties:
- qcom,sdx55-sdhci
- qcom,sdx65-sdhci
- qcom,sdx75-sdhci
+ - qcom,shikra-sdhci
- qcom,sm6115-sdhci
- qcom,sm6125-sdhci
- qcom,sm6350-sdhci
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible
2026-05-04 7:13 [PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible Monish Chunara
@ 2026-05-06 8:23 ` Krzysztof Kozlowski
2026-05-08 10:06 ` Monish Chunara
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-06 8:23 UTC (permalink / raw)
To: Monish Chunara
Cc: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, linux-mmc, devicetree,
linux-kernel, Nitin Rawat, Pradeep Pragallapati, Komal Bajaj
On Mon, May 04, 2026 at 12:43:34PM +0530, Monish Chunara wrote:
> Add the MSM SDHCI compatible name to support both eMMC and SD card for
> Shikra, which uses 'shikra' as the fallback SoC.
How shikra can use shikra fallback?
>
> The SDHCI controller on Shikra is based on MSM SDHCI v5 IP. Hence,
> document the compatible with "qcom,sdhci-msm-v5" as the fallback.
And here you repeat or state something contradictory. So shikra or
sdhci-msm-v5?
This should be just one paragraph where you state the device and its
compatibility with any other devices or interfaces.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible
2026-05-06 8:23 ` Krzysztof Kozlowski
@ 2026-05-08 10:06 ` Monish Chunara
0 siblings, 0 replies; 3+ messages in thread
From: Monish Chunara @ 2026-05-08 10:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, linux-mmc, devicetree,
linux-kernel, Nitin Rawat, Pradeep Pragallapati, Komal Bajaj
On Wed, May 06, 2026 at 10:23:07AM +0200, Krzysztof Kozlowski wrote:
> On Mon, May 04, 2026 at 12:43:34PM +0530, Monish Chunara wrote:
> > Add the MSM SDHCI compatible name to support both eMMC and SD card for
> > Shikra, which uses 'shikra' as the fallback SoC.
>
> How shikra can use shikra fallback?
>
> >
> > The SDHCI controller on Shikra is based on MSM SDHCI v5 IP. Hence,
> > document the compatible with "qcom,sdhci-msm-v5" as the fallback.
>
> And here you repeat or state something contradictory. So shikra or
> sdhci-msm-v5?
>
> This should be just one paragraph where you state the device and its
> compatibility with any other devices or interfaces.
Will update commit text in next series with better clarity on the change.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-08 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-04 7:13 [PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible Monish Chunara
2026-05-06 8:23 ` Krzysztof Kozlowski
2026-05-08 10:06 ` Monish Chunara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox