* [PATCH v3] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common
@ 2026-05-04 6:49 Swati Agarwal
2026-05-05 6:52 ` Krzysztof Kozlowski
2026-05-05 12:52 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Swati Agarwal @ 2026-05-04 6:49 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel,
Swati Agarwal
Qualcomm TLMM-based pin controllers share the same gpio-hog binding
semantics across multiple SoCs. The gpio-hog pattern currently defined in
qcom,ipq4019-pinctrl.yaml and qcom,sdm845-pinctrl.yaml are not SOC specific
and applies to all TLMM controllers.
Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml so
that it can be reused by other Qualcomm TLMM pinctrl bindings and avoid
schema duplication.
Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
---
Changes in v3:
Move the gpio-hog patternProperties for qcom,ipq4019-pinctrl.yaml to
qcom,tlmm-common.yaml.
Changes in v2:
Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml
Link to v2:
https://lore.kernel.org/all/20260430140118.3684018-1-swati.agarwal@oss.qualcomm.com/
Link to v1:
https://lore.kernel.org/all/20260417152014.3000797-1-swati.agarwal@oss.qualcomm.com/
---
.../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml | 5 -----
.../devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 5 -----
.../devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 6 ++++++
3 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml
index cc5de9f77680..de9a3e67e1bb 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml
@@ -36,11 +36,6 @@ patternProperties:
$ref: "#/$defs/qcom-ipq4019-tlmm-state"
additionalProperties: false
- "-hog(-[0-9]+)?$":
- type: object
- required:
- - gpio-hog
-
$defs:
qcom-ipq4019-tlmm-state:
type: object
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
index 4fcac2e55b55..3b33daedc018 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
@@ -42,11 +42,6 @@ patternProperties:
$ref: "#/$defs/qcom-sdm845-tlmm-state"
additionalProperties: false
- "-hog(-[0-9]+)?$":
- type: object
- required:
- - gpio-hog
-
$defs:
qcom-sdm845-tlmm-state:
type: object
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
index aae3dcf6cac8..aec72e8c0621 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
@@ -51,6 +51,12 @@ properties:
should not be accessed by the OS. Please see the ../gpio/gpio.txt for more
information.
+patternProperties:
+ "-hog(-[0-9]+)?$":
+ type: object
+ required:
+ - gpio-hog
+
allOf:
- $ref: pinctrl.yaml#
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common
2026-05-04 6:49 [PATCH v3] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common Swati Agarwal
@ 2026-05-05 6:52 ` Krzysztof Kozlowski
2026-05-05 12:52 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-05 6:52 UTC (permalink / raw)
To: Swati Agarwal
Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Mon, May 04, 2026 at 12:19:36PM +0530, Swati Agarwal wrote:
> Qualcomm TLMM-based pin controllers share the same gpio-hog binding
> semantics across multiple SoCs. The gpio-hog pattern currently defined in
> qcom,ipq4019-pinctrl.yaml and qcom,sdm845-pinctrl.yaml are not SOC specific
> and applies to all TLMM controllers.
>
> Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml so
> that it can be reused by other Qualcomm TLMM pinctrl bindings and avoid
> schema duplication.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> ---
> Changes in v3:
> Move the gpio-hog patternProperties for qcom,ipq4019-pinctrl.yaml to
> qcom,tlmm-common.yaml.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common
2026-05-04 6:49 [PATCH v3] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common Swati Agarwal
2026-05-05 6:52 ` Krzysztof Kozlowski
@ 2026-05-05 12:52 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2026-05-05 12:52 UTC (permalink / raw)
To: Swati Agarwal
Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Mon, May 4, 2026 at 8:49 AM Swati Agarwal
<swati.agarwal@oss.qualcomm.com> wrote:
> Qualcomm TLMM-based pin controllers share the same gpio-hog binding
> semantics across multiple SoCs. The gpio-hog pattern currently defined in
> qcom,ipq4019-pinctrl.yaml and qcom,sdm845-pinctrl.yaml are not SOC specific
> and applies to all TLMM controllers.
>
> Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml so
> that it can be reused by other Qualcomm TLMM pinctrl bindings and avoid
> schema duplication.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-05 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-04 6:49 [PATCH v3] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common Swati Agarwal
2026-05-05 6:52 ` Krzysztof Kozlowski
2026-05-05 12:52 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox