From: Arun Muthusamy <arun.muthusamy@gaisler.com>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mkl@pengutronix.de, mailhol@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-can@vger.kernel.org,
Arun Muthusamy <arun.muthusamy@gaisler.com>
Subject: [PATCH v7 13/15] can: grcan: Add CANFD RX support alongside legacy CAN
Date: Fri, 8 May 2026 09:01:19 +0200 [thread overview]
Message-ID: <20260508070121.6918-14-arun.muthusamy@gaisler.com> (raw)
In-Reply-To: <20260508070121.6918-1-arun.muthusamy@gaisler.com>
Include CANFD RX support with the legacy CAN support, enabling
support for extended data payloads to provide higher bit rates.
Signed-off-by: Arun Muthusamy <arun.muthusamy@gaisler.com>
---
drivers/net/can/grcan.c | 72 +++++++++++++++++++++++++++--------------
1 file changed, 47 insertions(+), 25 deletions(-)
diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c
index 690e07c7b1ef..eba52701c882 100644
--- a/drivers/net/can/grcan.c
+++ b/drivers/net/can/grcan.c
@@ -235,6 +235,9 @@ struct grcan_registers {
#define GRCAN_TX_BRS BIT(25)
#define GRCAN_TX_FDF BIT(26)
+#define GRCAN_RX_BRS BIT(25)
+#define GRCAN_RX_FDF BIT(26)
+
/* Hardware capabilities */
struct grcan_hwcap {
/* CAN-FD capable, indicates GRCANFD IP.
@@ -1250,17 +1253,21 @@ static int grcan_numbds(int len)
static int grcan_receive(struct net_device *dev, int budget)
{
+ struct net_device_stats *stats = &dev->stats;
struct grcan_priv *priv = netdev_priv(dev);
- struct grcan_registers __iomem *regs = priv->regs;
+ struct grcan_registers __iomem *regs;
struct grcan_dma *dma = &priv->dma;
- struct net_device_stats *stats = &dev->stats;
+ u32 bds, copy_len, payload_offset;
+ struct grcan_msg_fragment *frag;
struct grcan_msg_header *hdr;
- struct can_frame *cf;
+ u32 wr, rd, dlc, startrd;
+ struct canfd_frame *cf;
+ int i, work_done = 0;
struct sk_buff *skb;
- u32 wr, rd, startrd;
u32 rtr, eff;
- int work_done = 0;
+ u8 *data;
+ regs = priv->regs;
rd = grcan_read_reg(®s->rxrd);
startrd = rd;
for (work_done = 0; work_done < budget; work_done++) {
@@ -1269,47 +1276,62 @@ static int grcan_receive(struct net_device *dev, int budget)
if (rd == wr)
break;
- /* Take care of packet */
- skb = alloc_can_skb(dev, &cf);
- if (skb == NULL) {
- netdev_err(dev,
- "dropping frame: skb allocation failed\n");
+ hdr = grcan_msg_header_at(&dma->rx, rd);
+ if (hdr->ctrl & GRCAN_RX_FDF)
+ skb = alloc_canfd_skb(dev, &cf);
+ else
+ skb = alloc_can_skb(dev, (struct can_frame **)&cf);
+
+ if (unlikely(!skb)) {
+ netdev_err(dev, "dropping frame: skb allocation failed\n");
stats->rx_dropped++;
continue;
}
- hdr = grcan_msg_header_at(&dma->rx, rd);
+ dlc = FIELD_GET(GRCAN_MSG_DLC_MASK, hdr->ctrl);
+ if (hdr->ctrl & GRCAN_RX_FDF)
+ cf->len = can_fd_dlc2len(dlc);
+ else
+ cf->len = can_cc_dlc2len(dlc);
+
+ bds = grcan_numbds(cf->len);
+ payload_offset = 0;
+ data = cf->data;
eff = hdr->id & GRCAN_MSG_IDE;
rtr = hdr->id & GRCAN_MSG_RTR;
if (eff) {
- cf->can_id = ((hdr->id & GRCAN_MSG_EID)
- >> GRCAN_MSG_EID_BIT);
+ cf->can_id = FIELD_GET(GRCAN_MSG_EID_MASK, hdr->id);
cf->can_id |= CAN_EFF_FLAG;
} else {
- cf->can_id = ((hdr->id & GRCAN_MSG_BID)
- >> GRCAN_MSG_BID_BIT);
+ cf->can_id = FIELD_GET(GRCAN_MSG_BID_MASK, hdr->id);
}
-
- cf->len = can_cc_dlc2len((hdr->ctrl & GRCAN_MSG_DLC)
- >> GRCAN_MSG_DLC_BIT);
-
if (rtr) {
cf->can_id |= CAN_RTR_FLAG;
+ rd = grcan_ring_add(rd, GRCAN_MSG_SIZE, dma->rx.size);
} else {
- if (cf->len > 0)
- memcpy(cf->data, hdr->data,
- min_t(u32, cf->len, CAN_MAX_DLEN));
+ copy_len = min_t(u32, cf->len, CAN_MAX_DLEN);
+ memcpy(data, hdr->data, copy_len);
+ payload_offset += copy_len;
+
+ rd = grcan_ring_add(rd, GRCAN_MSG_SIZE, dma->rx.size);
+ for (i = 1; i < bds; i++) {
+ frag = grcan_msg_frag_at(&dma->rx, rd);
+
+ copy_len = min_t(u32, (u32)cf->len - payload_offset,
+ (u32)GRCAN_MSG_SIZE);
+ memcpy(data + payload_offset, frag->data, copy_len);
+ payload_offset += copy_len;
+
+ rd = grcan_ring_add(rd, GRCAN_MSG_SIZE, dma->rx.size);
+ }
stats->rx_bytes += cf->len;
}
stats->rx_packets++;
-
netif_receive_skb(skb);
-
- rd = grcan_ring_add(rd, GRCAN_MSG_SIZE, dma->rx.size);
}
/* Make sure everything is read before allowing hardware to
--
2.51.0
next prev parent reply other threads:[~2026-05-08 7:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 7:01 [PATCH v7 RESEND 00/15] can: grcan: Enhance driver with CANFD Support and Improvements Arun Muthusamy
2026-05-08 7:01 ` [PATCH v7 01/15] dt-bindings: Add vendor prefix for Frontgrade Gaisler AB Arun Muthusamy
2026-05-08 7:01 ` [PATCH v7 02/15] dt-bindings: net: can: gaisler,grcan: Convert to DT schema Arun Muthusamy
2026-05-08 18:37 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 03/15] MAINTAINERS: Add maintainers for GRCAN CAN network driver Arun Muthusamy
2026-05-08 7:01 ` [PATCH v7 04/15] can: grcan: Add clock handling Arun Muthusamy
2026-05-08 18:50 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 05/15] can: grcan: Replace bit timing macros with literal values Arun Muthusamy
2026-05-08 7:01 ` [PATCH v7 06/15] can: grcan: Simplify timing configuration Arun Muthusamy
2026-05-08 19:28 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 07/15] can: grcan: add FD capability detection and nominal bit-timing Arun Muthusamy
2026-05-08 19:45 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 08/15] can: grcan: set DMA mask for GRCAN and GRCANFD to 32-bit Arun Muthusamy
2026-05-08 19:53 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 09/15] can: grcan: Add saving and restoring of CAN FD baud-rate registers Arun Muthusamy
2026-05-08 21:35 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 10/15] can: grcan: Reserve space between cap and next register to align with address layout Arun Muthusamy
2026-05-08 7:01 ` [PATCH v7 11/15] can: grcan: Refactor GRCAN DMA buffer to use structured memory layout Arun Muthusamy
2026-05-08 22:03 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 12/15] can: grcan: Add CANFD TX support alongside legacy CAN Arun Muthusamy
2026-05-08 22:40 ` sashiko-bot
2026-05-08 7:01 ` Arun Muthusamy [this message]
2026-05-08 23:08 ` [PATCH v7 13/15] can: grcan: Add CANFD RX " sashiko-bot
2026-05-08 7:01 ` [PATCH v7 14/15] can: grcan: Update echo skb handling to match variable length CANFD frame Arun Muthusamy
2026-05-08 23:25 ` sashiko-bot
2026-05-08 7:01 ` [PATCH v7 15/15] can: grcan: Advertise CANFD capability Arun Muthusamy
2026-05-08 23:50 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508070121.6918-14-arun.muthusamy@gaisler.com \
--to=arun.muthusamy@gaisler.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox