Re: [PATCH 3/3] arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete Power Management: Missing 'sleep' states for camera MCLK pinctrls.
--

commit 3df184e361a5c8fe5a2bf34fc4785990c54c8020
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl

This commit defines pinctrl definitions to enable camera master clocks on the
Kaanapali platform.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
[ ... ]
> @@ -3903,6 +3903,62 @@ tlmm: pinctrl@f100000 {
>  			#interrupt-cells = <2>;
>  			wakeup-parent = <&pdc>;
>  
> +			cam0_default: cam0-default-state {
> +				pins = "gpio89";
> +				function = "cam_mclk";
> +				drive-strength = <2>;
> +				bias-disable;
> +			};

Should there also be corresponding sleep states defined for these MCLK pins?

Typically on Qualcomm platforms, camera sensor drivers request both default
and sleep states. The sleep state safely parks the pad, usually via
bias-pull-down, when the camera is powered off.

Without a sleep state, the MCLK pins might be left floating when powered off
due to the bias-disable setting here, which could cause power leakage. Other
camera pins in the Kaanapali device tree seem to follow the pattern of having
sleep states defined.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-knp-camera-v1-0-a18e289163fd@oss.qualcomm.com?part=3