From: sashiko-bot@kernel.org
To: "Charan Pedumuru" <charan.pedumuru@gmail.com>
Cc: conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] arm: dts: st: align node patterns with established convention
Date: Fri, 08 May 2026 22:15:08 +0000 [thread overview]
Message-ID: <20260508221508.AE480C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260508-st-mmc-v3-1-81c329ed28e8@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Renaming `sdhci` nodes to `mmc` in `stih407-family.dtsi` breaks node overrides in dependent device trees, causing MMC controllers to become non-functional.
--
commit 874b7326db9041ff83194d41b493b257577ea261
Author: Charan Pedumuru <charan.pedumuru@gmail.com>
arm: dts: st: align node patterns with established convention
This commit updates the device tree node patterns for ST MMC controllers to
match established conventions by renaming the sdhci nodes to mmc.
> diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
> index 3e6a0542e3aea..08acba209c564 100644
> --- a/arch/arm/boot/dts/st/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/st/stih407-family.dtsi
> @@ -596,7 +596,7 @@ spi@9542000 {
> status = "disabled";
> };
>
> - mmc0: sdhci@9060000 {
> + mmc0: mmc@9060000 {
Does this rename break device tree overrides in dependent files like
stih418-b2199.dts and stih410-b2260.dts?
If dependent board files override properties by reopening the nodes using
their exact path and old names (e.g., soc { mmc0: sdhci@9060000 { ... }; }),
changing the base node name here to mmc@9060000 will cause the device tree
compiler to create a new parallel node instead of merging the properties.
The original mmc@9060000 node would remain disabled, and the newly created
sdhci@9060000 node would lack the required compatible, reg, and interrupts
properties, which could prevent the MMC driver from probing correctly.
> compatible = "st,sdhci-stih407", "st,sdhci";
> status = "disabled";
> reg = <0x09060000 0x7ff>, <0x9061008 0x20>;
[ ... ]
> - mmc1: sdhci@9080000 {
> + mmc1: mmc@9080000 {
Could this node rename also cause similar override failures for dependent
files that override mmc1?
> compatible = "st,sdhci-stih407", "st,sdhci";
> status = "disabled";
> reg = <0x09080000 0x7ff>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-st-mmc-v3-0-81c329ed28e8@gmail.com?part=1
next prev parent reply other threads:[~2026-05-08 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 17:23 [PATCH v3 0/2] dt-bindings: mmc: st,sdhci: convert STMicroelectronics SDHCI-ST MMC/SD Controller controller binding to YAML Charan Pedumuru
2026-05-08 17:23 ` [PATCH v3 1/2] arm: dts: st: align node patterns with established convention Charan Pedumuru
2026-05-08 22:15 ` sashiko-bot [this message]
2026-05-08 17:23 ` [PATCH v3 2/2] dt-bindings: mmc: st,sdhci: convert to DT schema Charan Pedumuru
2026-05-08 22:22 ` sashiko-bot
2026-05-10 7:11 ` Charan Pedumuru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508221508.AE480C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox