Re: [PATCH v3 2/2] dt-bindings: mmc: st,sdhci: convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `minItems: 1` for `clock-names` and `reg-names` restricts them to exactly two items, breaking schema validation for existing device trees.
--

commit 66ec88f9e00b102af921864d0e0bf8b1b9e7f38d
Author: Charan Pedumuru <charan.pedumuru@gmail.com>
dt-bindings: mmc: st,sdhci: convert to DT schema

This commit converts the STMicroelectronics sdhci-st MMC/SD controller
binding to DT schema. It updates the clock and register properties to
support backward compatibility for single-item entries.

>     - In the legacy text binding, 'icn' was optional. Keep the clock list
>       flexible to preserve compatibility, although all existing in-tree DTS
>       files already provide both clocks.
>     - Document the optional "top-mmc-delay" register region and corresponding
>       reg-name in the YAML binding, as existing in-tree DTS files already use
>       both "mmc" and "top-mmc-delay" entries.

Are these descriptions accurate regarding all existing in-tree DTS files?

In arch/arm/boot/dts/st/stih407-family.dtsi, the mmc1 node defines only a
single register name (reg-names = "mmc"). Other device trees such as
arch/powerpc/boot/dts/fsp2.dts also define a single clock and register.

> diff --git a/Documentation/devicetree/bindings/mmc/st,sdhci.yaml b/Documentation/devicetree/bindings/mmc/st,sdhci.yaml
> new file mode 100644
> index 0000000000000..10e0e1ee6d5cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/st,sdhci.yaml

[ ... ]

> +  reg:
> +    minItems: 1
> +    items:
> +      - description: MMC controller registers
> +      - description: MMC delay/auxiliary registers
> +
> +  reg-names:
> +    items:
> +      - const: mmc
> +      - const: top-mmc-delay

Because items lists without an explicit minItems default to the length of
the list, does this strictly require two items for reg-names?

Will this cause make dtbs_check to fail for existing nodes like mmc1 that
only provide "mmc"? Should minItems: 1 be added here to allow single entries?

[ ... ]

> +  clocks:
> +    minItems: 1
> +    items:
> +      - description: Clock for the MMC controller
> +      - description: Interconnect (ICN) clock
> +
> +  clock-names:
> +    items:
> +      - const: mmc
> +      - const: icn

Similarly, does clock-names require minItems: 1 to match the flexibility
added to the clocks property and prevent schema validation errors on
single-clock configurations?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-st-mmc-v3-0-81c329ed28e8@gmail.com?part=2