From: sashiko-bot@kernel.org
To: "Manish Baing" <manishbaing2789@gmail.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v2] dt-bindings: pwm: stmpe: drop legacy binding
Date: Fri, 08 May 2026 22:49:53 +0000 [thread overview]
Message-ID: <20260508224954.7BD7BC2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260508184626.15938-1-manishbaing2789@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete Schema Migration / Missing Required Property Constraint
--
commit 652bd7fb646323b7de60d7d1fdac5400a5920f24
Author: Manish Baing <manishbaing2789@gmail.com>
dt-bindings: pwm: stmpe: drop legacy binding
The commit drops the legacy text binding for st,stmpe-pwm as it is allegedly
covered by the mfd schema st,stmpe.yaml.
> diff --git a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt b/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> deleted file mode 100644
> index f401316e0248b..0000000000000
> --- a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
[ ... ]
> -Required properties:
> -- compatible: should be:
> - - "st,stmpe-pwm"
Does dropping this file remove the only place enforcing the compatible string
as a required property?
Looking at Documentation/devicetree/bindings/mfd/st,stmpe.yaml, the pwm
subnode defines the compatible property but omits it from a required
list, unlike the touchscreen or keyboard-controller subnodes:
pwm:
type: object
$ref: /schemas/pwm/pwm.yaml#
unevaluatedProperties: false
properties:
compatible:
const: st,stmpe-pwm
"#pwm-cells":
const: 2
Without this text binding, a device tree node lacking the compatible string
will silently pass dt_binding_check schema validation.
It would then fail to probe at runtime because mfd_add_devices() relies on
matching the compatible string to map the device tree node to the instantiated
child device.
Could the yaml schema be fixed by adding compatible to a required list in the
pwm node before or in the same patch series as dropping the text binding?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260508184626.15938-1-manishbaing2789@gmail.com?part=1
prev parent reply other threads:[~2026-05-08 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 18:46 [PATCH v2] dt-bindings: pwm: stmpe: drop legacy binding Manish Baing
2026-05-08 22:49 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508224954.7BD7BC2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=manishbaing2789@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox