[PATCH v2] dt-bindings: pwm: stmpe: drop legacy binding

[PATCH v2] dt-bindings: pwm: stmpe: drop legacy binding

[Manish Baing]

The st,stmpe-pwm binding is already covered by the MFD schema
Documentation/devicetree/bindings/mfd/st,stmpe.yaml. Remove the
obsolete and redundant text binding file.

Signed-off-by: Manish Baing <manishbaing2789@gmail.com>
---
Changes in v2:
- Drop the TXT file instead of converting to YAML, as the
  functionality is already covered by st,stmpe.yaml.
- Update the commit subject and description to reflect the drop.

 .../devicetree/bindings/pwm/st,stmpe-pwm.txt   | 18 ------------------
 1 file changed, 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt

diff --git a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt b/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
deleted file mode 100644
index f401316e0248..000000000000
--- a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-== ST STMPE PWM controller ==
-
-This is a PWM block embedded in the ST Microelectronics STMPE
-(ST Multi-Purpose Expander) chips. The PWM is registered as a
-subdevices of the STMPE MFD device.
-
-Required properties:
-- compatible: should be:
-  - "st,stmpe-pwm"
-- #pwm-cells: should be 2. See pwm.yaml in this directory for a description of
-  the cells format.
-
-Example:
-
-pwm0: pwm {
-	compatible = "st,stmpe-pwm";
-	#pwm-cells = <2>;
-};
-- 
2.43.0

Re: [PATCH v2] dt-bindings: pwm: stmpe: drop legacy binding

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete Schema Migration / Missing Required Property Constraint
--

commit 652bd7fb646323b7de60d7d1fdac5400a5920f24
Author: Manish Baing <manishbaing2789@gmail.com>

dt-bindings: pwm: stmpe: drop legacy binding

The commit drops the legacy text binding for st,stmpe-pwm as it is allegedly
covered by the mfd schema st,stmpe.yaml.

> diff --git a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt b/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> deleted file mode 100644
> index f401316e0248b..0000000000000
> --- a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
[ ... ]
> -Required properties:
> -- compatible: should be:
> -  - "st,stmpe-pwm"

Does dropping this file remove the only place enforcing the compatible string
as a required property?

Looking at Documentation/devicetree/bindings/mfd/st,stmpe.yaml, the pwm
subnode defines the compatible property but omits it from a required
list, unlike the touchscreen or keyboard-controller subnodes:

  pwm:
    type: object
    $ref: /schemas/pwm/pwm.yaml#

    unevaluatedProperties: false

    properties:
      compatible:
        const: st,stmpe-pwm

      "#pwm-cells":
        const: 2

Without this text binding, a device tree node lacking the compatible string
will silently pass dt_binding_check schema validation.

It would then fail to probe at runtime because mfd_add_devices() relies on
matching the compatible string to map the device tree node to the instantiated
child device.

Could the yaml schema be fixed by adding compatible to a required list in the
pwm node before or in the same patch series as dropping the text binding?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508184626.15938-1-manishbaing2789@gmail.com?part=1