[PATCH v2] dt-bindings: rtc: epson,rx6110: Convert to DT Schema

[PATCH v2] dt-bindings: rtc: epson,rx6110: Convert to DT Schema

[Udaya Kiran Challa]

Convert the Epson RX6110 Real Time Clock devicetree binding
from the legacy text format to DT schema.

Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
---
Changelog:
Changes since v1:
- Reuse common SPI peripheral properties
- Drop redundant SPI-specific comment
- Remove unused labels from examples

Link to v1:https://lore.kernel.org/all/20260504183728.27412-1-challauday369@gmail.com/
---
 .../devicetree/bindings/rtc/epson,rx6110.yaml | 23 +++++++------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
index 32d15a014f91..b51d39ef75e4 100644
--- a/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
+++ b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
@@ -14,6 +14,9 @@ description: |
 maintainers:
   - Alexandre Belloni <alexandre.belloni@bootlin.com>
 
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
 properties:
   compatible:
     const: epson,rx6110
@@ -21,24 +24,14 @@ properties:
   reg:
     maxItems: 1
 
-  # SPI-specific properties
-  spi-cs-high:
-    type: boolean
-    description: RX6110 needs chipselect high
-
-  spi-cpha:
-    type: boolean
-    description: RX6110 works with SPI shifted clock phase
-
-  spi-cpol:
-    type: boolean
-    description: RX6110 works with SPI inverse clock polarity
+  spi-cpha: true
+  spi-cpol: true
 
 required:
   - compatible
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   # I2C mode
@@ -47,7 +40,7 @@ examples:
       #address-cells = <1>;
       #size-cells = <0>;
 
-      rtc1: rtc@32 {
+      rtc@32 {
         compatible = "epson,rx6110";
         reg = <0x32>;
       };
@@ -59,7 +52,7 @@ examples:
       #address-cells = <1>;
       #size-cells = <0>;
 
-      rtc2: rtc@3 {
+      rtc@3 {
         compatible = "epson,rx6110";
         reg = <3>;
         spi-cs-high;
-- 
2.43.0

Re: [PATCH v2] dt-bindings: rtc: epson,rx6110: Convert to DT Schema

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

On Sat, May 09, 2026 at 02:30:51PM +0530, Udaya Kiran Challa wrote:
> Convert the Epson RX6110 Real Time Clock devicetree binding
> from the legacy text format to DT schema.
> 
> Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
> ---
> Changelog:
> Changes since v1:
> - Reuse common SPI peripheral properties
> - Drop redundant SPI-specific comment
> - Remove unused labels from examples
> 
> Link to v1:https://lore.kernel.org/all/20260504183728.27412-1-challauday369@gmail.com/

Seemingly there are 2 v2s of this.
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2] dt-bindings: rtc: epson,rx6110: Convert to DT Schema

[Udaya Kiran Challa]

Convert the Epson RX6110 Real Time Clock devicetree binding
from the legacy text format to DT schema.

Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
---
Changelog:
Changes since v1:
- Reuse common SPI peripheral properties
- Drop redundant SPI-specific comment
- Remove unused labels from examples

Link to v1:https://lore.kernel.org/all/20260504183728.27412-1-challauday369@gmail.com/
---
 .../devicetree/bindings/rtc/epson,rx6110.txt  | 39 ------------
 .../devicetree/bindings/rtc/epson,rx6110.yaml | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 39 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/epson,rx6110.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx6110.yaml

diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
deleted file mode 100644
index 3dc313e01f77..000000000000
--- a/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
+++ /dev/null
@@ -1,39 +0,0 @@
-Epson RX6110 Real Time Clock
-============================
-
-The Epson RX6110 can be used with SPI or I2C busses. The kind of
-bus depends on the SPISEL pin and can not be configured via software.
-
-I2C mode
---------
-
-Required properties:
-  - compatible: should be: "epson,rx6110"
-  - reg : the I2C address of the device for I2C
-
-Example:
-
-	rtc: rtc@32 {
-		compatible = "epson,rx6110"
-		reg = <0x32>;
-	};
-
-SPI mode
---------
-
-Required properties:
-  - compatible: should be: "epson,rx6110"
-  - reg: chip select number
-  - spi-cs-high: RX6110 needs chipselect high
-  - spi-cpha: RX6110 works with SPI shifted clock phase
-  - spi-cpol: RX6110 works with SPI inverse clock polarity
-
-Example:
-
-	rtc: rtc@3 {
-		compatible = "epson,rx6110"
-		reg = <3>
-		spi-cs-high;
-		spi-cpha;
-		spi-cpol;
-	};
diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
new file mode 100644
index 000000000000..b51d39ef75e4
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/epson,rx6110.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Epson RX6110 Real Time Clock
+
+description: |
+  The Epson RX6110 can be used with SPI or I2C busses.
+  The kind of bus depends on the SPISEL pin and can not be
+  configured via software.
+
+maintainers:
+  - Alexandre Belloni <alexandre.belloni@bootlin.com>
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    const: epson,rx6110
+
+  reg:
+    maxItems: 1
+
+  spi-cpha: true
+  spi-cpol: true
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  # I2C mode
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      rtc@32 {
+        compatible = "epson,rx6110";
+        reg = <0x32>;
+      };
+    };
+
+  # SPI mode
+  - |
+    spi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      rtc@3 {
+        compatible = "epson,rx6110";
+        reg = <3>;
+        spi-cs-high;
+        spi-cpha;
+        spi-cpol;
+      };
+    };
-- 
2.43.0

Re: [PATCH v2] dt-bindings: rtc: epson,rx6110: Convert to DT Schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The YAML binding omits a reference to the core RTC subsystem schema (`rtc.yaml`).
- [Medium] The strict requirement for SPI-specific properties was lost during the schema conversion.
--

commit 83ad9493a42cbad1f11db8ac3498c9be50a357d1
Author: Udaya Kiran Challa <challauday369@gmail.com>

dt-bindings: rtc: epson,rx6110: Convert to DT Schema

This commit converts the Epson RX6110 Real Time Clock devicetree binding
from the legacy text format to DT schema.

> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
[ ... ]
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#

Should this also include a reference to rtc.yaml# in the allOf block?
Without it, since unevaluatedProperties is false, won't valid standard RTC
properties like start-year or aux-voltage-chargeable cause validation
errors? This omission appears to introduce a functional regression by
bypassing the standard nodename checks provided by the core schema.

[ ... ]
> +  spi-cpha: true
> +  spi-cpol: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false

The legacy text binding listed spi-cs-high, spi-cpha, and spi-cpol as
mandatory required properties when the device operates in SPI mode.

Because they are omitted from the required list to support I2C mode, won't
misconfigured SPI nodes missing these hardware configuration flags now
silently pass validation? Would adding a conditional allOf/if block be
appropriate to enforce these properties for SPI configurations and avoid
this regression?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260509095713.5818-1-challauday369@gmail.com?part=1

Re: [PATCH v2] dt-bindings: rtc: epson,rx6110: Convert to DT Schema

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]

On Sat, May 09, 2026 at 10:27:02AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] The YAML binding omits a reference to the core RTC subsystem schema (`rtc.yaml`).
> - [Medium] The strict requirement for SPI-specific properties was lost during the schema conversion.
> --
> 
> commit 83ad9493a42cbad1f11db8ac3498c9be50a357d1
> Author: Udaya Kiran Challa <challauday369@gmail.com>
> 
> dt-bindings: rtc: epson,rx6110: Convert to DT Schema
> 
> This commit converts the Epson RX6110 Real Time Clock devicetree binding
> from the legacy text format to DT schema.
> 
> > diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
> > new file mode 100644
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/epson,rx6110.yaml
> [ ... ]
> > +allOf:
> > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> 
> Should this also include a reference to rtc.yaml# in the allOf block?
> Without it, since unevaluatedProperties is false, won't valid standard RTC
> properties like start-year or aux-voltage-chargeable cause validation
> errors? This omission appears to introduce a functional regression by
> bypassing the standard nodename checks provided by the core schema.
> 
> [ ... ]
> > +  spi-cpha: true
> > +  spi-cpol: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> 
> The legacy text binding listed spi-cs-high, spi-cpha, and spi-cpol as
> mandatory required properties when the device operates in SPI mode.

+ the fact that cpha/cpol are listed with : true, and spi-cs-high isn't
which is confusing IMO.

> Because they are omitted from the required list to support I2C mode, won't
> misconfigured SPI nodes missing these hardware configuration flags now
> silently pass validation? Would adding a conditional allOf/if block be
> appropriate to enforce these properties for SPI configurations and avoid
> this regression?

Don't do this, since it requires knowing what the parent node is.
If anything, make it something like
if: oneOf: <> then: allOf: <>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]