Re: [PATCH v4 6/8] arm64: dts: rockchip: add radxa camera 4k on rock 5b+ cam0

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The CSI-2 receiver input endpoint (`&csi2_in`) is missing the mandatory `bus-type` property.
--

commit 3116df0f04df5ee4f52ff3fd8e1f890c40b802e7
Author: Michael Riesch <michael.riesch@collabora.com>

arm64: dts: rockchip: add radxa camera 4k on rock 5b+ cam0

This commit adds a device tree overlay for the Radxa Camera 4K (featuring
the Sony IMX415 image sensor) to be applied on the Radxa ROCK 5B+ CAM0 port.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso
> new file mode 100644
> index 0000000000000..ee9ecf68a8866
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso

[ ... ]

> +&csi2_in {
> +	csi2_input: endpoint {
> +		data-lanes = <1 2 3 4>;
> +		link-frequencies = /bits/ 64 <445500000>;
> +		remote-endpoint = <&imx415_output>;

Is the bus-type property missing here?

The rockchip,rk3568-mipi-csi2.yaml binding requires the bus-type property
in the input port endpoint (e.g., bus-type = <4>; for D-PHY). 

While the V4L2 core detects the data-lanes property and gracefully defaults
the bus type to V4L2_MBUS_CSI2_DPHY at runtime, omitting bus-type here
violates the device tree schema and triggers a dtbs_check warning.

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-rk3588-vicap-v4-0-6a6cd6f7c90b@collabora.com?part=6