Re: [PATCH v4 7/8] arm64: dts: rockchip: add radxa camera 4k on rock 5b+ cam1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `ovdd-supply` for the IMX415 sensor is incorrectly assigned to the 2.9V regulator (`savdd_cam1`) instead of the 1.8V regulator (`siovdd_cam1`), which may cause hardware damage.
--

commit e46c0d86040d3c76c24e08d7bc4d0bb3f3567d45
Author: Michael Riesch <michael.riesch@collabora.com>

arm64: dts: rockchip: add radxa camera 4k on rock 5b+ cam1

Add device tree overlay for the Radxa Camera 4K (featuring the Sony IMX415
image sensor) to applied on the Radxa ROCK 5B+ CAM1 port.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso
> new file mode 100644
> index 0000000000000..96b8df4ed3540
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso
[ ... ]
> @@ -0,0 +1,99 @@
[ ... ]
> +	siovdd_cam1: regulator-siovdd-cam1 {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-name = "siovdd_cam1";
> +		vin-supply = <&vcc_3v3_s3>;
> +	};
> +};
> +
> +&i2c4 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	cam1_imx415: camera-sensor@1a {
> +		compatible = "sony,imx415";
> +		reg = <0x1a>;
> +		assigned-clocks = <&cru CLK_MIPI_CAMARAOUT_M4>;
> +		assigned-clock-rates = <37125000>;
> +		avdd-supply = <&savdd_cam1>;
> +		clocks = <&cru CLK_MIPI_CAMARAOUT_M4>;
> +		dvdd-supply = <&sdvdd_cam1>;
> +		orientation = <2>; /* External */
> +		ovdd-supply = <&savdd_cam1>;

Does this code assign the wrong regulator to ovdd-supply?

It looks like ovdd-supply is using the 2.9V regulator (savdd_cam1) instead
of the 1.8V regulator (siovdd_cam1) defined earlier in the overlay.

Supplying 2.9V to the 1.8V digital I/O domain of the IMX415 sensor might
exceed its voltage rating and potentially cause hardware damage. Should this
property be updated to reference siovdd_cam1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-rk3588-vicap-v4-0-6a6cd6f7c90b@collabora.com?part=7