Re: [PATCH v5 08/14] media: iris: Rename clock and power domain macros to use vcodec prefix

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Stale goto labels were not renamed to match the newly introduced `VCODEC` and `AXI_CTRL` terminology, leaving the refactoring incomplete.
--

commit f3b910e5c28a152c2333978c6b950a8247d50b04
Author: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>

media: iris: Rename clock and power domain macros to use vcodec prefix

This commit renames the generic clock and power domain macros in the
iris driver to use a 'vcodec' prefix. This accommodates secondary core
enums and provides more meaningful names.

> diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c
> index 02e100a4045fc..92c0b06bbbff4 100644
> --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c
> +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c
[ ... ]
> @@ -162,15 +163,15 @@ static int iris_vpu4x_enable_hardware_clocks(struct iris_core *core, u32 efuse_v
>  {
>  	int ret;
>  
> -	ret = iris_prepare_enable_clock(core, IRIS_AXI_CLK);
> +	ret = iris_prepare_enable_clock(core, IRIS_AXI_VCODEC_CLK);
>  	if (ret)
>  		return ret;
>  
> -	ret = iris_prepare_enable_clock(core, IRIS_HW_FREERUN_CLK);
> +	ret = iris_prepare_enable_clock(core, IRIS_VCODEC_FREERUN_CLK);
>  	if (ret)
>  		goto disable_axi_clock;

This isn't a bug, but should the disable_axi_clock label be renamed to
match the new IRIS_AXI_VCODEC_CLK macro name? 

>  
> -	ret = iris_prepare_enable_clock(core, IRIS_HW_CLK);
> +	ret = iris_prepare_enable_clock(core, IRIS_VCODEC_CLK);
>  	if (ret)
>  		goto disable_hw_free_run_clock;

[ ... ]

> @@ -198,11 +199,11 @@ static int iris_vpu4x_enable_hardware_clocks(struct iris_core *core, u32 efuse_v
>  disable_bse_hw_clock:
>  	iris_disable_unprepare_clock(core, IRIS_BSE_HW_CLK);
>  disable_hw_clock:
> -	iris_disable_unprepare_clock(core, IRIS_HW_CLK);
> +	iris_disable_unprepare_clock(core, IRIS_VCODEC_CLK);

Similarly, would it make sense to update labels like disable_hw_clock
to reflect the VCODEC terminology?

>  disable_hw_free_run_clock:
> -	iris_disable_unprepare_clock(core, IRIS_HW_FREERUN_CLK);
> +	iris_disable_unprepare_clock(core, IRIS_VCODEC_FREERUN_CLK);
>  disable_axi_clock:
> -	iris_disable_unprepare_clock(core, IRIS_AXI_CLK);
> +	iris_disable_unprepare_clock(core, IRIS_AXI_VCODEC_CLK);
>  
>  	return ret;
>  }

> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c
> index f1f9e04b7c31f..73c094bc4311e 100644
> --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c
> +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c
[ ... ]
> @@ -400,7 +401,7 @@ int iris_vpu35_vpu4x_power_on_controller(struct iris_core *core)
>  err_disable_ctrl_free_clk:
>  	iris_disable_unprepare_clock(core, IRIS_CTRL_FREERUN_CLK);
>  err_disable_axi1_clk:
> -	iris_disable_unprepare_clock(core, IRIS_AXI1_CLK);
> +	iris_disable_unprepare_clock(core, IRIS_AXI_CTRL_CLK);

Could this err_disable_axi1_clk label also be renamed to match the new
IRIS_AXI_CTRL_CLK macro?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260509-glymur-v5-0-7fbb340c5dbd@oss.qualcomm.com?part=8