Re: [PATCH v3 1/5] dt-bindings: iio: dac: ad5504: add output-range and missing gpios

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `vlogic-supply` property is missing from the device tree example despite the commit message claiming to provide a complete usage example.
--

commit c85189a6dcd792e207cd5be70833e861a180c568
Author: Taha Ed-Dafili <0rayn.dev@gmail.com>

dt-bindings: iio: dac: ad5504: add output-range and missing gpios

This commit introduces properties for configuring the R_SEL pin on AD5504
devices. It also adds vlogic-supply, clr-gpios, ldac-gpios, datasheet links,
and updates the usage example.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml
> index 9c2c038683b4d..e0123dceaa336 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml

[ ... ]

> @@ -45,6 +78,10 @@ examples:
>              compatible = "adi,ad5504";
>              vcc-supply = <&dac_vcc>;
>              interrupts = <55 IRQ_TYPE_EDGE_FALLING>;
> +
> +            output-range-microvolt = <0 60000000>;
> +            clr-gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
> +            ldac-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;

This isn't a bug, but the commit message states it provides a complete usage
example including the newly added vlogic-supply. Should vlogic-supply be
included in this example node?

>          };
>      };
>  ...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260509142047.30302-1-0rayn.dev@gmail.com?part=1