Re: [PATCH v3 3/5] iio: dac: ad5504: Align headers with IWYU principle

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing lock protection for shared SPI DMA buffer 'st->data'.
--

commit 4601fb5b571a0290d2e1fd539e465ce5c954b588
Author: Taha Ed-Dafili <0rayn.dev@gmail.com>

iio: dac: ad5504: Align headers with IWYU principle

This commit updates the header inclusions to follow the Include What You Use
principle and ensures they are sorted alphabetically. Unused headers are
removed, and required ones are added.

> diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
> index 03ce37e2c616a..57e6eeed26efb 100644
> --- a/drivers/iio/dac/ad5504.c
> +++ b/drivers/iio/dac/ad5504.c
> @@ -5,16 +5,19 @@
>   * Copyright 2011 Analog Devices Inc.
>   */
>  
> -#include <linux/bitops.h>
> +#include <asm/byteorder.h>
> +#include <linux/array_size.h>
> +#include <linux/bits.h>
>  #include <linux/device.h>

[ ... ]

>  #include <linux/sysfs.h>
> +#include <linux/types.h>
>  
>  #include <linux/iio/dac/ad5504.h>
>  #include <linux/iio/events.h>

This isn't a regression from this patch, but while reviewing this driver
I noticed a concurrency issue.

The driver allocates a shared tx/rx buffer st->data for SPI transfers.
Multiple sysfs callbacks, such as ad5504_read_raw(), ad5504_write_raw(),
and ad5504_write_dac_powerdown(), directly access and modify st->data
without any driver-level locking.

If thread A calls ad5504_spi_read() and thread B calls ad5504_spi_write()
concurrently, can thread B overwrite st->data[0] while thread A's
spi_sync_transfer() is in progress?

Modifying a DMA buffer while a transfer is in flight violates SPI API
contracts, corrupts the transmitted data, and causes the DAC to receive
incorrect commands.

Additionally, read-modify-write operations on driver state like
st->pwr_down_mask lack locking. Could concurrent writes to different
channels' powerdown files race?

Would it be appropriate to introduce a lock to serialize sysfs operations?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260509142047.30302-1-0rayn.dev@gmail.com?part=3