Re: [PATCH 1/2] dt-bindings: arm: qcom: document the Ayaneo Pocket DS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string 'ayaneo,pocketds' omits a hyphen between words, violating typical devicetree naming conventions and internal consistency.
--

commit 3beb9c18c4855d596e09aceb2276fb3c8a70aff3
Author: Teguh Sobirin <teguh@sobir.in>

dt-bindings: arm: qcom: document the Ayaneo Pocket DS

This commit documents the device tree bindings for the Ayaneo Pocket DS
gaming console. It maps the new device to the Qualcomm QCS8550 and SM8550
platforms.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 2741c07e9f416..f130a6b092b95 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
[ ... ]
> @@ -1107,6 +1107,12 @@ properties:
>            - const: qcom,qcs8550
>            - const: qcom,sm8550
>  
> +      - items:
> +          - enum:
> +              - ayaneo,pocketds

This isn't a bug, but should this compatible string include a hyphen
between the words (ayaneo,pocket-ds)? Standard devicetree naming
conventions typically use hyphens to separate words, and it would match
the existing format used for the Ayaneo Pocket S2 below.

> +          - const: qcom,qcs8550
> +          - const: qcom,sm8550
> +
>        - items:
>            - enum:
>                - ayaneo,pocket-s2

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260510-pocketds-v1-0-cf05acec06af@gmail.com?part=1