Re: [PATCH] dt-bindings: misc: add documentation for Xilinx AXI-Stream FIFO IP core

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The YAML binding schema is incomplete and sets `additionalProperties: false`, which rejects valid device trees and breaks driver probing.
- [Low] The commit introduces a new YAML binding but fails to remove the existing text-based binding, leading to duplicated and conflicting documentation.
--

commit a25eb1af928bc942c4ddef43a8d5e91efa619819
Author: Kartik Nair <contact.kartikn@gmail.com>

dt-bindings: misc: add documentation for Xilinx AXI-Stream FIFO IP core

This patch adds device tree binding documentation for the Xilinx AXI-Stream
FIFO IP core. It introduces a new YAML schema to document the compatible
strings used by the axis-fifo driver.

Does this update also need to remove the existing text-based binding at
drivers/staging/axis-fifo/axis-fifo.txt? Keeping the legacy text file
alongside the new YAML schema introduces duplicated and conflicting
documentation.

> diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> new file mode 100644
> index 0000000000000..597699034f134
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> @@ -0,0 +1,44 @@
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - xlnx,axi-fifo-mm-s-4.1
> +      - xlnx,axi-fifo-mm-s-4.2
> +      - xlnx,axi-fifo-mm-s-4.3
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1

The drivers/staging/axis-fifo/axis-fifo.c driver requires several vendor
specific properties to probe successfully, such as
xlnx,axi-str-rxd-tdata-width, xlnx,axi-str-txd-tdata-width,
xlnx,rx-fifo-depth, xlnx,tx-fifo-depth, xlnx,use-rx-data, and
xlnx,use-tx-data.

Are these properties missing from the schema?

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false

If the vendor properties are added to the device tree to allow the driver
to probe, won't setting additionalProperties to false cause the schema
validation to fail?

Device trees that pass this strict schema would then fail at runtime since
the driver will abort the probe when the missing properties are not found.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260510190908.400-1-contact.kartikn@gmail.com?part=1