Re: [PATCH v1 1/9 RESEND] ARM: tegra: lg-x3: Complete video device graph

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Invalid 'orientation' property in 'onnn,mt9m114' node.
- [Low] Inaccurate 'compatible' string for the ST EEPROM.
--

commit df21cf02565cc61e444d4c72eaf7861addc90fb0
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: lg-x3: Complete video device graph
    
Add front and rear camera nodes and interlink them with Tegra CSI and VI.
Adjust camera PMIC voltages to better fit requirements and fix the focuser
node.

> diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts b/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts
> index 414117fd43824..896639599c126 100644
> --- a/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts
[ ... ]
> @@ -118,6 +118,52 @@ rmi4-f1a@1a {
>  		};
>  	};
>  
> +	i2c@7000c500 {
> +		/* Aptina 1/6" HD SOC (MT9M114) */
> +		front-camera@48 {
> +			compatible = "onnn,mt9m114";
> +			reg = <0x48>;
> +
> +			clocks = <&tegra_car TEGRA30_CLK_CSUS>;
> +
> +			reset-gpios = <&gpio TEGRA_GPIO(BB, 5) GPIO_ACTIVE_LOW>;
> +
> +			vddio-supply = <&vio_1v8_front>;
> +			vdd-supply = <&vt_1v8_front>;
> +			vaa-supply = <&vt_2v8_front>;
> +
> +			orientation = <0>; /* Front camera */

Could this property cause a dtbs_check schema validation error?

The device tree binding for this sensor enforces additionalProperties: false
at the top level and does not appear to include a reference to
/schemas/media/video-interface-devices.yaml, which defines standard camera
properties like orientation.

> +
> +			assigned-clocks = <&tegra_car TEGRA30_CLK_VI_SENSOR>,
> +					  <&tegra_car TEGRA30_CLK_CSUS>;
[ ... ]
> diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> index 768e201456d8a..d2a5904cebedd 100644
> --- a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
[ ... ]
> @@ -1112,29 +1198,68 @@ dw9714: coil@c {
[ ... ]
> +		/* rear camera sensor eeprom m24c08 from ST */
> +		m24c08: eeprom@50 {
> +			compatible = "atmel,24c08";

This isn't a bug, but since the comment notes this is an ST Microelectronics
EEPROM, would it be better to use a compatible string array that includes the
actual manufacturer followed by the Atmel fallback?

For example: compatible = "st,24c08", "atmel,24c08";

> +			reg = <0x50>;
> +
> +			/* if high then WP is on, if low then off */
> +			wp-gpios = <&gpio TEGRA_GPIO(K, 3) GPIO_ACTIVE_HIGH>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511074859.24930-1-clamor95@gmail.com?part=1