Re: [PATCH v1 4/9 RESEND] ARM: tegra: grouper: Add support for front camera

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The 'orientation' property is not allowed by the 'aptina,mi1040' binding schema.
- [Low] Devicetree node name 'front-camera@48' does not follow generic naming conventions.
--

commit c5071430d670662429d8b5764f80cefdddb8903b
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: grouper: Add support for front camera

This commit adds the front camera video path to the Tegra 30 Nexus 7
(grouper) device tree. It includes the necessary host1x, vi, and csi
endpoints, a new camera node on the I2C bus, and updates the relevant
power supply bindings.

> diff --git a/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi
> index 15f53babdc217..892d718294dd1 100644
> --- a/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi

[ ... ]

> @@ -890,6 +978,36 @@ light-sensor@1c {
>  			vdd-supply = <&vdd_3v3_sys>;
>  		};
>  
> +		/* Aptina 1/6" HD SOC (MI1040) */
> +		front-camera@48 {

This isn't a bug, but does the node name front-camera@48 follow the Devicetree
generic naming conventions?

It might be better to use a generic name like camera@48 to avoid dtbs_check
warnings.

> +			compatible = "aptina,mi1040";
> +			reg = <0x48>;
> +
> +			clocks = <&tegra_car TEGRA30_CLK_CSUS>;
> +
> +			reset-gpios = <&gpio TEGRA_GPIO(O, 0) GPIO_ACTIVE_LOW>;
> +
> +			vddio-supply = <&avdd_cam1>;
> +			vdd-supply = <&vddio_cam>;
> +			vaa-supply = <&avdd_cam1>;
> +
> +			orientation = <0>; /* Front camera */

Is the orientation property supported by the aptina,mi1040 binding?

The corresponding schema onnn,mt9m114.yaml sets additionalProperties: false
at the root level and does not define the orientation property. It also
does not reference the common video-interface-devices.yaml schema at the
device node level.

Could this inclusion cause a schema validation error during dtbs_check?

> +
> +			assigned-clocks = <&tegra_car TEGRA30_CLK_VI_SENSOR>,
> +					  <&tegra_car TEGRA30_CLK_CSUS>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511074859.24930-1-clamor95@gmail.com?part=4