[PATCH] arm64: dts: qcom: ipq5210: add the download mode support

[PATCH] arm64: dts: qcom: ipq5210: add the download mode support

[Kathiravan Thirumoorthy]

Enable support for download mode to collect RAM dumps in case
of system crash, facilitating post mortem analysis.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq5210.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
index 3761eb03ab24..cd587eef0018 100644
--- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
@@ -75,6 +75,7 @@ optee {
 
 		scm {
 			compatible = "qcom,scm-ipq5210", "qcom,scm";
+			qcom,dload-mode = <&tcsr 0x25100>;
 		};
 	};
 
@@ -160,6 +161,11 @@ tcsr_mutex: hwlock@1905000 {
 			#hwlock-cells = <1>;
 		};
 
+		tcsr: syscon@1937000 {
+			compatible = "qcom,tcsr-ipq5210", "syscon";
+			reg = <0x0 0x01937000 0x0 0x2b000>;
+		};
+
 		qupv3: geniqup@1ac0000 {
 			compatible = "qcom,geni-se-qup";
 			reg = <0x0 0x01ac0000 0x0 0x2000>;

---
base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
change-id: 20260511-ipq5210_dload_support-4336d9627beb
prerequisite-change-id: 20260511-ipq5210_tcsr_binding-5aef0d2eaeca:v1
prerequisite-patch-id: 93b818cd4feadea099a037157877d5a033545b53

Best regards,
--  
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: ipq5210: add the download mode support

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a new compatible string `qcom,tcsr-ipq5210` for the TCSR node in `ipq5210.dtsi` without adding it to the corresponding device tree binding schema (`Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml`).
--

commit 9435d5db06195f6fe5ee397b1257dbedf5ed5ea2
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: add the download mode support

Enable support for download mode to collect RAM dumps in case
of system crash, facilitating post mortem analysis.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 3761eb03ab246..cd587eef00180 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
[ ... ]
> @@ -160,6 +161,11 @@ tcsr_mutex: hwlock@1905000 {
>  			#hwlock-cells = <1>;
>  		};
>  
> +		tcsr: syscon@1937000 {
> +			compatible = "qcom,tcsr-ipq5210", "syscon";

Should this new compatible string also be added to the corresponding device
tree binding schema? 

It appears that "qcom,tcsr-ipq5210" is not documented in
Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml, which might cause
dtbs_check validation to emit warnings about an undocumented compatible
string.

> +			reg = <0x0 0x01937000 0x0 0x2b000>;
> +		};
> +
>  		qupv3: geniqup@1ac0000 {
>  			compatible = "qcom,geni-se-qup";
>  			reg = <0x0 0x01ac0000 0x0 0x2000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-ipq5210_dload_support-v1-1-5609c6b8330e@oss.qualcomm.com?part=1