Re: [PATCH v2 1/2] dt-bindings: i2c: Add i2c-shared-gpio

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `minimum` and `maximum` constraints on the child node's `reg` property are structurally invalid and will be silently ignored during schema validation.
- [Medium] The compatible string in the commit message does not match the actual code implementation.
--

commit 5af80521617a83464e505c8a8c5b9d9829717a38
Author: Markus Stockhausen <markus.stockhausen@gmx.de>

dt-bindings: i2c: Add i2c-shared-gpio

This commit documents the driver for bitbanged GPIO I2C buses with shared
SCL lines.

> dt-bindings: i2c: Add i2c-shared-gpio

This isn't a bug, but the commit subject and description refer to the
binding as i2c-shared-gpio, whereas the actual compatible string and file
name introduced in the patch use i2c-gpio-shared.

> diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio-shared.yaml b/Documentation/devicetree/bindings/i2c/i2c-gpio-shared.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio-shared.yaml
[ ... ]
> +    properties:
> +      reg:
> +        items:
> +          - minimum: 0
> +            maximum: 31

Will these minimum and maximum constraints be silently ignored during schema
validation?

Because dt-schema decodes standard properties like reg internally as a matrix
(an array of arrays), applying JSON Schema numeric constraints inside an items
list evaluates them against an array instance instead of a numeric integer.
Since JSON Schema ignores numeric constraints on non-numeric types,
out-of-bounds reg values might silently pass schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511162528.84508-1-markus.stockhausen@gmx.de?part=1