From: Rob Herring <robh@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Markus Stockhausen <markus.stockhausen@gmx.de>,
wsa+renesas@sang-engineering.com, andi.shyti@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>
Subject: Re: [PATCH v2 0/2] i2c: Add i2c-shared-gpio driver
Date: Wed, 13 May 2026 07:11:35 -0500 [thread overview]
Message-ID: <20260513121135.GA432696-robh@kernel.org> (raw)
In-Reply-To: <CAMRc=Mc-EbMu3eUrMA5UDCEp-xzbyndy8_U8OjfcTDJcATThQg@mail.gmail.com>
On Tue, May 12, 2026 at 01:00:08PM +0200, Bartosz Golaszewski wrote:
> On Mon, May 11, 2026 at 6:25 PM Markus Stockhausen
> <markus.stockhausen@gmx.de> wrote:
> >
> > This series adds support for hardware designs where multiple I2C
> > gpio based busses are realized with dedicated SDA lines and a
> > shared SCL line. This way N busses can be realized with N+1 gpios.
> >
> > Currently there are several Realtek switches that make use of
> > this design. Samples are:
> >
> > HPE 1920-48G
> > Linksys LGS310C
> > Zyxel GS1920-24
> > Engenius EWS2910
> > D-Link DGS-1250
> >
> > While at first glance this might be a usecase for the new shared
> > gpio architecture, discussion and testing shows that this is not
> > trivial at all. A shared gpio is handled by a voting system. If
> > there at least one user that votes for the GPIO to be "high",
> > it stays high.
> >
> > So the implementation manages several classic bitbang buses with
> > locking/unlocking in the pre_xfer/post_xfer handlers.
> >
> > Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
> >
>
> Hi!
>
> A couple high-level issues. You'll soon hear from the DT maintainers
> and they'll ask if the i2c-shared-gpio compatible corresponds with an
> actual piece of hardware on the board. It does not, so the bindings
> will be rejected.
Perhaps you missed I've already commented on this. I'm actually fine
with the binding at a high level.
But if we want to model it as N i2c-gpio nodes I'm fine with that as
well.
Rob
next prev parent reply other threads:[~2026-05-13 12:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 16:25 [PATCH v2 0/2] i2c: Add i2c-shared-gpio driver Markus Stockhausen
2026-05-11 16:25 ` [PATCH v2 1/2] dt-bindings: i2c: Add i2c-shared-gpio Markus Stockhausen
2026-05-11 17:36 ` Rob Herring (Arm)
2026-05-12 20:59 ` sashiko-bot
2026-05-11 16:25 ` [PATCH v2 2/2] i2c: Add driver for gpio based busses with shared SCL Markus Stockhausen
2026-05-12 21:44 ` sashiko-bot
2026-05-12 11:00 ` [PATCH v2 0/2] i2c: Add i2c-shared-gpio driver Bartosz Golaszewski
2026-05-13 5:33 ` AW: " markus.stockhausen
2026-05-13 7:12 ` Wolfram Sang
2026-05-13 7:26 ` Bartosz Golaszewski
2026-05-13 7:47 ` Wolfram Sang
2026-05-13 7:50 ` Bartosz Golaszewski
2026-05-13 12:11 ` Rob Herring [this message]
2026-05-13 12:25 ` markus.stockhausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513121135.GA432696-robh@kernel.org \
--to=robh@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=markus.stockhausen@gmx.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox