Re: [PATCH v1 1/6] dt-bindings: usb: ci-hdrc-usb2: Document nvidia,external-control property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The vendor-specific property `nvidia,external-control` is not constrained to NVIDIA-compatible devices.
--

commit 2fc8a800ab9c1409217fd7f6b370e99b9cc6d3e7
Author: Svyatoslav Ryhel <clamor95@gmail.com>

dt-bindings: usb: ci-hdrc-usb2: Document nvidia,external-control property
    
This commit adds the nvidia,external-control property to the ci-hdrc-usb2
binding. It is used to indicate that the controller is configured externally,
such as by a modem requiring precise bus control.

> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml

[ ... ]

> @@ -75,6 +75,13 @@ properties:
>      type: boolean
>      deprecated: true
>  
> +  nvidia,external-control:
> +    description:
> +      Indicates that the controller is configured externally and that the host
> +      should not attempt to touch it. Usually used by a modem which requires
> +      precise bus configuration.
> +    type: boolean
> +

Could this property be constrained to NVIDIA-compatible devices using an
allOf block with an if-then statement?

Because it is defined at the top level of the shared binding, unrelated
device nodes could incorrectly include nvidia,external-control and still
pass schema validation.

>    ulpi:
>      type: object
>      additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511135703.62470-1-clamor95@gmail.com?part=1