From: Yixun Lan <dlan@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: Chukun Pan <amadeus@jmu.edu.cn>,
Andre Heider <a.heider@gmail.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
Yixun Lan <dlan@kernel.org>
Subject: [PATCH] riscv: dts: spacemit: drop unnecessary power supply from PCIe
Date: Wed, 13 May 2026 02:14:51 +0000 [thread overview]
Message-ID: <20260513-k1-pcie-fix-supply-v1-1-4eecbdd44ebe@kernel.org> (raw)
The PCIe Root Complex found on the SpacemiT K1 SoC does not require
external power supply, this match with the dt-binding documentation[1],
Instead it's the sub node of PCIe ports which should add vpcie3v3 power
supply. So, explicitly remove "vpcie3v3-supply" property from the PCIe
controller.
Link: https://lore.kernel.org/all/20251113214540.2623070-4-elder@riscstar.com/ [1]
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
The problem was introduced at the time of PCIe DTS first committed to
kernel, the vpcie3v3-supply should be added to PCIe ports instead of PCIe
RC node.
Refer the example dts of Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
I'm not adding the Fixes tag, as this doesn't cause any severe bug, thus
not necessary to do the back port..
---
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 --
arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
index e20daa50a152..c70081856606 100644
--- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
@@ -316,7 +316,6 @@ &pcie1_port {
};
&pcie1 {
- vpcie3v3-supply = <&pcie_vcc_3v3>;
status = "okay";
};
@@ -332,7 +331,6 @@ &pcie2_port {
};
&pcie2 {
- vpcie3v3-supply = <&pcie_vcc_3v3>;
status = "okay";
};
diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
index afaad59e6bce..7e5915023eaa 100644
--- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
@@ -313,7 +313,6 @@ &pcie1_port {
};
&pcie1 {
- vpcie3v3-supply = <&pcie_vcc_3v3>;
status = "okay";
};
@@ -329,7 +328,6 @@ &pcie2_port {
};
&pcie2 {
- vpcie3v3-supply = <&pcie_vcc_3v3>;
status = "okay";
};
---
base-commit: f068b204555ad62d6a841a49feb4ea8c4f45b25c
change-id: 20260512-k1-pcie-fix-supply-d12f6d50d8d4
Best regards,
--
Yixun Lan <dlan@kernel.org>
next reply other threads:[~2026-05-13 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 2:14 Yixun Lan [this message]
2026-05-13 8:24 ` [PATCH] riscv: dts: spacemit: drop unnecessary power supply from PCIe Anand Moon
2026-05-14 0:54 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513-k1-pcie-fix-supply-v1-1-4eecbdd44ebe@kernel.org \
--to=dlan@kernel.org \
--cc=a.heider@gmail.com \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox