Re: [PATCH v1 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng controller.

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Critical] The commit silently removes the `starfive,jh8100-trng` compatible string, breaking backward ABI compatibility.
- [High] The schema enforces an invalid device tree compatible array order (generic fallback before specific device) for the new JHB100 SoC.
--

commit eafedaf1268d7bf5cd0934352607dcf457417047
Author: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>

dt-bindings: Add bindings for StarFive JHB100 SoC trng controller.

This commit adds device tree bindings for the TRNG controller on the StarFive
JHB100 SoC.

> diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> index 4639247e9e510..11346d77b2f6d 100644
> --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> @@ -13,8 +13,8 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - const: starfive,jh8100-trng

Does this break backward ABI compatibility?

Device tree bindings are considered kernel ABI, and removing this line drops
support for any existing device trees that use the starfive,jh8100-trng
compatible string. The commit message doesn't document or justify the removal
of the JH8100 support.

>            - const: starfive,jh7110-trng
> +          - const: starfive,jhb100-trng

Does this enforce an invalid device tree compatible array order?

In YAML binding schemas, the items list enforces the exact sequence required in
the device tree source. By placing starfive,jh7110-trng before
starfive,jhb100-trng, this sequence puts the generic fallback before the
specific hardware variant.

This violates the device tree specification which mandates that the most
specific hardware match must come first.

To support both variants falling back to jh7110, would it be better to use
an enum for the first item containing both specific strings, followed by the
fallback constant?

>        - const: starfive,jh7110-trng

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512062404.4540-1-lianfeng.ouyang@starfivetech.com?part=1