Re: [PATCH 2/2] interconnect: qcom: eliza: Add SDCC1 slave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The newly added `qhs_sdc1` node is missing from the `bcm_cn0` Bus Clock Manager (BCM) configuration.
--

commit d28b10055037729ce3f753377d62887c5022c5c1
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

interconnect: qcom: eliza: Add SDCC1 slave node

The Eliza interconnect provider is missing the SDCC1 CNOC CFG slave
node. Add qhs_sdc1 to the provider node table and qsm_cfg links so
SDCC1 interconnect paths can resolve to a provider node.

> diff --git a/drivers/interconnect/qcom/eliza.c b/drivers/interconnect/qcom/eliza.c
> index a4f7903f0524d..6d12a1c3c034f 100644
> --- a/drivers/interconnect/qcom/eliza.c
> +++ b/drivers/interconnect/qcom/eliza.c
[ ... ]
> @@ -392,7 +398,7 @@ static struct qcom_icc_node qsm_cfg = {
>  			&qhs_mss_cfg, &qhs_pcie_0_cfg,
>  			&qhs_prng, &qhs_qdss_cfg,
>  			&qhs_qspi, &qhs_qup1,
> -			&qhs_qup2, &qhs_sdc2,
> +			&qhs_qup2, &qhs_sdc1, &qhs_sdc2,

Should the newly added qhs_sdc1 node also be added to the bcm_cn0 Bus Clock
Manager configuration?

Currently bcm_cn0 contains qhs_sdc2, but qhs_sdc1 is missing:

static struct qcom_icc_bcm bcm_cn0 = {
        .name = "CN0",
        .enable_mask = BIT(0),
        .keepalive = true,
        .num_nodes = 43,
        .nodes = { &qsm_cfg, &qhs_ahb2phy0,
...
                   &qhs_qspi, &qhs_sdc2,
...
};

Without being added to the nodes array and incrementing num_nodes, it appears
any bandwidth requested by interconnect paths targeting SDCC1 will be ignored.

Will this cause a regression where the SDCC1 config path is prevented from
scaling the CN0 bus clocks?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-eliza-interconnect-add-missing-sdcc1-slave-node-v1-0-b1edf81bac3b@oss.qualcomm.com?part=2