Re: [PATCH 1/2] arm64: dts: amlogic: t7: Fix pwm_ao_c pinmux definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit provides an incomplete fix by resolving missing pin group suffixes for `pwm_ao_c` but overlooking identical bugs for `pwm_ao_g`, `pwm_ao_h`, and `pwm_vs` in the same device tree file.
--

commit 45b298237b81cf91a3c02cc08237c80e6356d308
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

arm64: dts: amlogic: t7: Fix pwm_ao_c pinmux definitions

The pwm_ao_c pin node was incomplete: it was missing the group name
suffix, conflating two distinct pin groups (pwm_ao_c_d and pwm_ao_c_e)
into a single, ambiguous entry.

> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> index 7fe72c94ed623..62f6b9baad28b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> @@ -400,9 +400,17 @@ mux {
>  					};
>  				};
>  
> -				pwm_ao_c_pins: pwm-ao-c {
> +				pwm_ao_c_d_pins: pwm-ao-c-d {
>  					mux {
> -						groups = "pwm_ao_c";
> +						groups = "pwm_ao_c_d";

Should we also fix the regressions for pwm_ao_g, pwm_ao_h, and pwm_vs in
this commit?

In this same device tree file, pwm_ao_g_pins, pwm_ao_h_pins, and pwm_vs_pins
are defined using the same generic string pattern:

arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi:
				pwm_ao_g_pins: pwm-ao-g {
					mux {
						groups = "pwm_ao_g";
						function = "pwm_ao_g";
						bias-disable;
					};
				};

In drivers/pinctrl/meson/pinctrl-amlogic-t7.c, these generic groups do not
exist as valid pin arrays. The driver only defines suffixed variants like
pwm_ao_g_d11, pwm_ao_g_d7, pwm_ao_g_e, pwm_ao_h_d5, pwm_ao_h_d10, pwm_vs_y,
and pwm_vs_h.

If any future or out-of-tree board tries to use these existing nodes, won't
it result in a pinctrl lookup failure at runtime?

> +						function = "pwm_ao_c";
> +						bias-disable;
> +					};
> +				};
> +
> +				pwm_ao_c_e_pins: pwm-ao-c-e {
> +					mux {
> +						groups = "pwm_ao_c_e";
>  						function = "pwm_ao_c";
>  						bias-disable;
>  					};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-add-kvim4-sysled-v1-0-7178719a43e7@aliel.fr?part=1