Re: [PATCH 2/2] arm64: dts: amlogic: t7: khadas-vim4: add PWM-driven status LED

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The child node of `pwm-leds` is named `status`, which violates the DT schema bindings for PWM LEDs.
--

commit 4d1f2b73cb8a598488da21baaa8d88280487e6f6
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

arm64: dts: amlogic: t7: khadas-vim4: add PWM-driven status LED

This commit adds a new pwm-leds node with a heartbeat trigger to the VIM4
board devicetree. It also enables the pwm_ao_cd controller and reorders the
xtal-clk node.

> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> index 69d6118ba57e7..c41525a34b721 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
[ ... ]
> @@ -60,6 +53,16 @@ dc_in: regulator-dc-in {
>  		regulator-always-on;
>  	};
>  
> +	pwm-leds {
> +		compatible = "pwm-leds";
> +
> +		status {

Will this child node name trigger a devicetree schema validation warning?

The PWM LEDs device tree binding schema restricts child node names using a
pattern property. It expects child nodes to match the regular expression
^led(-[0-9a-f]+)?$.

Since this node is named status, will dtbs_check treat it as an invalid
additional node?

> +			linux,default-trigger="heartbeat";
> +			max-brightness = <255>;
> +			pwms = <&pwm_ao_cd 0 30040 0>;
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-add-kvim4-sysled-v1-0-7178719a43e7@aliel.fr?part=2