Re: [PATCH V6 03/11] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Polling for reset completion immediately after a soft reset will cause probe to fail due to a bus read error.
--

commit 62a44073ad81f2d638c1665cd828465dfd85d6f7
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add inv_icm42607 Core Driver

This commit introduces the core driver component for the inv_icm42607 IMU,
setting up initial configuration, reset handling, and register definitions.

[ ... ]
> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> new file mode 100644
> index 0000000000000..0baf4763b0a7d
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
[ ... ]
> +static int inv_icm42607_setup(struct inv_icm42607_state *st,
> +			      inv_icm42607_bus_setup bus_setup)
> +{
[ ... ]
> +	ret = regmap_write(st->map, INV_ICM42607_REG_SIGNAL_PATH_RESET,
> +			   INV_ICM42607_SIGNAL_PATH_RESET_SOFT_RESET);
> +	if (ret)
> +		return ret;
> +
> +	/*
> +	 * Datasheet only specifies a reset period wait of 1ms for a
> +	 * power-on reset, but not a soft reset so not waiting here.
> +	 */
> +	ret = regmap_read_poll_timeout(st->map, INV_ICM42607_REG_INT_STATUS,
> +				       val, val & INV_ICM42607_INT_STATUS_RESET_DONE,
> +				       INV_ICM42607_RESET_TIME_MS * 100,
> +				       INV_ICM42607_RESET_TIME_MS * 1000);

Could this cause the probe to fail due to a bus read error?

When a soft reset is triggered, the device's digital core restarts, making
the interface temporarily unresponsive. Since regmap_read_poll_timeout
performs its first read immediately, the read will likely return a bus error.

Because regmap_read_poll_timeout evaluates its exit condition on any error
returned by the read operation, it will abort immediately rather than retrying
the read.

Would it be safer to insert a small sleep delay before attempting to read from
the device after initiating the soft reset?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512221634.256747-1-macroalpha82@gmail.com?part=3