Re: [PATCH V6 05/11] iio: imu: inv_icm42607: Add PM support for icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Misleading comment in `inv_icm42607_resume()` regarding runtime PM state.
--

commit 5e3ef42dfba709e36dacf1125d8f13cfabbf3f5c
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add PM support for icm42607
    
Add power management support for the ICM42607 device driver.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> index 6119379ca6a8b..dfd2fed7bf1e6 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c

[ ... ]

> +/*
> + * System resume gets the system back on and restores the sensors state.
> + * Manually put runtime power management in system active state.
> + */

This isn't a bug, but the comment mentions manually putting runtime power
management in the system active state.

However, the function correctly does not call any PM core APIs (such as
pm_runtime_set_active()) to alter the runtime PM status. The driver
checks pm_runtime_suspended() to avoid waking up hardware that was already
runtime-suspended, ensuring the hardware state perfectly aligns with the PM
core's state.

Could this comment be updated or removed to prevent confusion?

> +static int inv_icm42607_resume(struct device *dev)
> +{
> +	struct inv_icm42607_state *st = dev_get_drvdata(dev);
> +	int ret;
> +
> +	guard(mutex)(&st->lock);
> +
> +	if (pm_runtime_suspended(dev))
> +		return 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512221634.256747-1-macroalpha82@gmail.com?part=5