From: sashiko-bot@kernel.org
To: tze.yee.ng@altera.com
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: socfpga: use consistent QSPI boot partition label
Date: Thu, 14 May 2026 02:44:24 +0000 [thread overview]
Message-ID: <20260514024425.5E423C19425@smtp.kernel.org> (raw)
In-Reply-To: <eff34df0c67d39a26d20ec91eda8dd9e15f9f5cc.1778658884.git.tze.yee.ng@altera.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Renaming the MTD partition label breaks userspace ABI.
--
commit 4ade0c1cd1fb03537998130680736791486edcdb
Author: Tze Yee Ng <tze.yee.ng@altera.com>
arm64: dts: socfpga: use consistent QSPI boot partition label
This commit aligns the QSPI boot partition label across multiple SoCFPGA board
DTS files. It changes the label from u-boot to Boot and fpga data to match
the combined boot and FPGA image layout.
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index 262bb3e8e5c72..5ce825dd6afb0 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> @@ -86,7 +86,7 @@ partitions {
> #size-cells = <1>;
>
> qspi_boot: partition@0 {
> - label = "u-boot";
> + label = "Boot and fpga data";
Does renaming this partition label break userspace ABI compatibility?
Device tree MTD partition labels are exposed to userspace through /proc/mtd
and sysfs, and are often used by utilities like mtd-utils or software update
scripts to locate partitions by name rather than relying on dynamic device
nodes.
The u-boot label has been present in this file since commit a63766f32d62c
(February 2025). Changing the label to Boot and fpga data might break existing
userspace systems that rely on the old name to perform firmware updates.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/eff34df0c67d39a26d20ec91eda8dd9e15f9f5cc.1778658884.git.tze.yee.ng@altera.com?part=1
prev parent reply other threads:[~2026-05-14 2:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 8:05 [PATCH] arm64: dts: socfpga: use consistent QSPI boot partition label tze.yee.ng
2026-05-14 2:44 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514024425.5E423C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tze.yee.ng@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox