Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: socfpga: use consistent QSPI boot partition label
@ 2026-05-13  8:05 tze.yee.ng
  2026-05-14  2:44 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: tze.yee.ng @ 2026-05-13  8:05 UTC (permalink / raw)
  To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel
  Cc: adrian.ho.yin.ng, muhammad.nazim.amirul.nazle.asmade

From: Tze Yee Ng <tze.yee.ng@altera.com>

Several SoCFPGA board DTS files labeled the first QSPI MTD partition
(qspi_boot / partition@0 under fixed-partitions) as "u-boot" while
others already used "Boot and fpga data". Align the QSPI boot
partition label only so naming matches the combined boot + FPGA
image layout and stays consistent across Agilex, N5X, and Stratix 10
SoCDK variants.

No QSPI partition layout or reg properties are changed.

Signed-off-by: Tze Yee Ng <tze.yee.ng@altera.com>
---
 arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts         | 2 +-
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts         | 2 +-
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts    | 2 +-
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts
index 14b299f19f3a..f0a0964540a9 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts
@@ -107,7 +107,7 @@ partitions {
 			#size-cells = <1>;
 
 			qspi_boot: partition@0 {
-				label = "u-boot";
+				label = "Boot and fpga data";
 				reg = <0x0 0x00c00000>;
 			};
 
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
index 262bb3e8e5c7..5ce825dd6afb 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
@@ -86,7 +86,7 @@ partitions {
 			#size-cells = <1>;
 
 			qspi_boot: partition@0 {
-				label = "u-boot";
+				label = "Boot and fpga data";
 				reg = <0x0 0x04200000>;
 			};
 
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts
index f71e1280c778..63b4a3814131 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts
@@ -101,7 +101,7 @@ partitions {
 			#size-cells = <1>;
 
 			qspi_boot: partition@0 {
-				label = "u-boot";
+				label = "Boot and fpga data";
 				reg = <0x0 0x00c00000>;
 			};
 
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts
index 1831402d8808..23076fe8961f 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts
@@ -84,7 +84,7 @@ partitions {
 			#size-cells = <1>;
 
 			qspi_boot: partition@0 {
-				label = "u-boot";
+				label = "Boot and fpga data";
 				reg = <0x0 0x04200000>;
 			};
 
-- 
2.43.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: socfpga: use consistent QSPI boot partition label
  2026-05-13  8:05 [PATCH] arm64: dts: socfpga: use consistent QSPI boot partition label tze.yee.ng
@ 2026-05-14  2:44 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-05-14  2:44 UTC (permalink / raw)
  To: tze.yee.ng; +Cc: conor+dt, robh, devicetree, krzk+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Renaming the MTD partition label breaks userspace ABI.
--

commit 4ade0c1cd1fb03537998130680736791486edcdb
Author: Tze Yee Ng <tze.yee.ng@altera.com>

arm64: dts: socfpga: use consistent QSPI boot partition label

This commit aligns the QSPI boot partition label across multiple SoCFPGA board
DTS files. It changes the label from u-boot to Boot and fpga data to match
the combined boot and FPGA image layout.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index 262bb3e8e5c72..5ce825dd6afb0 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> @@ -86,7 +86,7 @@ partitions {
>  			#size-cells = <1>;
>  
>  			qspi_boot: partition@0 {
> -				label = "u-boot";
> +				label = "Boot and fpga data";

Does renaming this partition label break userspace ABI compatibility?

Device tree MTD partition labels are exposed to userspace through /proc/mtd
and sysfs, and are often used by utilities like mtd-utils or software update
scripts to locate partitions by name rather than relying on dynamic device
nodes.

The u-boot label has been present in this file since commit a63766f32d62c
(February 2025). Changing the label to Boot and fpga data might break existing
userspace systems that rely on the old name to perform firmware updates.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/eff34df0c67d39a26d20ec91eda8dd9e15f9f5cc.1778658884.git.tze.yee.ng@altera.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-14  2:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13  8:05 [PATCH] arm64: dts: socfpga: use consistent QSPI boot partition label tze.yee.ng
2026-05-14  2:44 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox