Re: [PATCH v3 08/17] ASoC: simple-amplifier: Remove DAPM widgets and routes from the ASoC component driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Probe fails unconditionally for non-Device Tree instantiations (platform board files, ACPI PRP0001, or CONFIG_OF disabled).
--

commit a564ff83aa42e00d34fe9812df9996695059dbc5
Author: Herve Codina <herve.codina@bootlin.com>

ASoC: simple-amplifier: Remove DAPM widgets and routes from the ASoC component driver

This patch moves DAPM tables from the ASoC component driver to the device
compatible string matching data. This allows the simple-amplifier driver to
configure different DAPM widgets and routes dynamically during probe based
on the compatible string.

> diff --git a/sound/soc/codecs/simple-amplifier.c b/sound/soc/codecs/simple-amplifier.c
> index 231e84ab4c0e3..3e644c1c26960 100644
> --- a/sound/soc/codecs/simple-amplifier.c
> +++ b/sound/soc/codecs/simple-amplifier.c
[ ... ]
> @@ -75,6 +111,10 @@ static int simple_amp_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	platform_set_drvdata(pdev, simple_amp);
>  
> +	simple_amp->data = of_device_get_match_data(dev);
> +	if (!simple_amp->data)
> +		return -EINVAL;
> +

Will this cause the probe function to fail unconditionally on non-Device
Tree platforms?

Since the driver does not depend on CONFIG_OF, it can be built and used on
systems without Device Tree. If CONFIG_OF is disabled, or if the device is
instantiated via ACPI PRP0001 where dev->of_node is NULL, the call to
of_device_get_match_data() will evaluate to NULL.

Because probe now returns -EINVAL when the match data is NULL, this looks
like it will prevent the driver from probing entirely on those platforms. 

Could this use device_get_match_data() instead to safely support non-DT
systems?

>  	simple_amp->gpiod_enable = devm_gpiod_get_optional(dev, "enable",
>  							   GPIOD_OUT_LOW);
>  	if (IS_ERR(simple_amp->gpiod_enable))

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513081702.317117-1-herve.codina@bootlin.com?part=8