Re: [PATCH 2/2] clk: qcom: nord: negcc: add missing definition for the USB2 PHY reset

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly introduced UAPI macro for the USB2 PHY reset is incorrectly named `NE_GCC_QUSB3PHY_PRIM_BCR` instead of `NE_GCC_QUSB2PHY_PRIM_BCR`.
--

commit 6d297fb76d38d25ccff03c1716dff37d01275b24
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

clk: qcom: nord: negcc: add missing definition for the USB2 PHY reset

This commit adds the missing USB2 PHY reset definition to the negcc clock
driver and its bindings. This enables adding the USB nodes in the device
tree.

> diff --git a/drivers/clk/qcom/negcc-nord.c b/drivers/clk/qcom/negcc-nord.c
> index 1aa24e2784e53..31442d39924a6 100644
> --- a/drivers/clk/qcom/negcc-nord.c
> +++ b/drivers/clk/qcom/negcc-nord.c
> @@ -1918,6 +1918,7 @@ static const struct qcom_reset_map ne_gcc_nord_resets[] = {
>  	[NE_GCC_USB3_PHY_SEC_BCR] = { 0x2d000 },
>  	[NE_GCC_USB3PHY_PHY_PRIM_BCR] = { 0x2b004 },
>  	[NE_GCC_USB3PHY_PHY_SEC_BCR] = { 0x2d004 },
> +	[NE_GCC_QUSB3PHY_PRIM_BCR] = { 0x2e000 },

Should this be NE_GCC_QUSB2PHY_PRIM_BCR instead of NE_GCC_QUSB3PHY_PRIM_BCR?

The commit message explicitly states the intention to add the USB2 PHY reset,
and Qualcomm conventions typically use QUSB2 for USB 2.0 PHYs. Since this
macro is part of the device tree bindings, correcting this typo before it
merges will prevent the QUSB3 name from becoming part of the permanent ABI.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-nord-clk-usb2-phy-v1-0-8eafcb2d5129@oss.qualcomm.com?part=2