Re: [PATCH 1/2] dt-bindings: clock: qcom: add missing definition for the USB2 PHY reset

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added reset macro is incorrectly named `NE_GCC_QUSB3PHY_PRIM_BCR` instead of `NE_GCC_QUSB2PHY_PRIM_BCR`, contradicting the commit message.
--

commit 995687d91ac26d49f12e0c08bcd404ce73e33d6c
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

dt-bindings: clock: qcom: add missing definition for the USB2 PHY reset

This commit adds the missing USB2 PHY reset definition to the nord-negcc
clock bindings header. This provides the definition needed to add the USB
nodes in the device tree.

> diff --git a/include/dt-bindings/clock/qcom,nord-negcc.h b/include/dt-bindings/clock/qcom,nord-negcc.h
> index 95f333d8e1aa7..c2d048d9fc9e9 100644
> --- a/include/dt-bindings/clock/qcom,nord-negcc.h
> +++ b/include/dt-bindings/clock/qcom,nord-negcc.h

[ ... ]

> @@ -120,5 +120,6 @@
>  #define NE_GCC_USB3_PHY_SEC_BCR					10
>  #define NE_GCC_USB3PHY_PHY_PRIM_BCR				11
>  #define NE_GCC_USB3PHY_PHY_SEC_BCR				12
> +#define NE_GCC_QUSB3PHY_PRIM_BCR				13

The commit message indicates this patch adds the USB2 PHY reset definition,
but the introduced macro is named NE_GCC_QUSB3PHY_PRIM_BCR.

Is this a typo? Should the macro be named NE_GCC_QUSB2PHY_PRIM_BCR to reflect
a USB2 PHY rather than a USB3 PHY before it becomes locked into the
dt-bindings API?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-nord-clk-usb2-phy-v1-0-8eafcb2d5129@oss.qualcomm.com?part=1